Skip to content

Clarify JSX usage in notifications expanded viewdocs: add note explai…#2921

Open
knisaci wants to merge 1 commit into
MetaMask:mainfrom
knisaci:patch-1
Open

Clarify JSX usage in notifications expanded viewdocs: add note explai…#2921
knisaci wants to merge 1 commit into
MetaMask:mainfrom
knisaci:patch-1

Conversation

@knisaci
Copy link
Copy Markdown

@knisaci knisaci commented May 18, 2026

…ning JSX requirement for expanded notification view

The notifications page switches from plain JS to JSX in the expanded view example without explanation, which can confuse new developers.

Added a sentence clarifying that the content field requires JSX components such as Box and Text, with a link to the Custom UI docs for context.

Fixes #2895

Description

Issue(s) fixed

Fixes #

Preview

Checklist

  • If this PR updates or adds documentation content that changes or adds technical meaning, it has received an approval from an engineer or DevRel from the relevant team.
  • If this PR updates or adds documentation content, it has received an approval from a technical writer.

External contributor checklist

  • I've read the contribution guidelines.
  • I've created a new issue (or assigned myself to an existing issue) describing what this PR addresses.

Note

Low Risk
Low risk documentation-only change that clarifies usage; no runtime behavior or APIs are modified.

Overview
Clarifies the notifications expanded-view docs by explicitly stating that the content field must be authored using JSX components (e.g., Box, Text) and links readers to the Custom UI documentation for background before following the example.

Reviewed by Cursor Bugbot for commit f205c48. Bugbot is set up for automated code reviews on this repo. Configure here.

…ning JSX requirement for expanded notification view

The notifications page switches from plain JS to JSX in the expanded 
view example without explanation, which can confuse new developers.

Added a sentence clarifying that the content field requires JSX 
components such as Box and Text, with a link to the Custom UI docs 
for context.

Fixes MetaMask#2895
@knisaci knisaci requested review from a team as code owners May 18, 2026 22:18
@vercel
Copy link
Copy Markdown

vercel Bot commented May 18, 2026

@knisaci is attempting to deploy a commit to the Consensys Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Notifications page switches code style without explanation (plain JS to JSX)

2 participants