Clarify JSX usage in notifications expanded viewdocs: add note explai…#2921
Open
knisaci wants to merge 1 commit into
Open
Clarify JSX usage in notifications expanded viewdocs: add note explai…#2921knisaci wants to merge 1 commit into
knisaci wants to merge 1 commit into
Conversation
…ning JSX requirement for expanded notification view The notifications page switches from plain JS to JSX in the expanded view example without explanation, which can confuse new developers. Added a sentence clarifying that the content field requires JSX components such as Box and Text, with a link to the Custom UI docs for context. Fixes MetaMask#2895
|
@knisaci is attempting to deploy a commit to the Consensys Team on Vercel. A member of the Team first needs to authorize it. |
lannathompson65-arch
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ning JSX requirement for expanded notification view
The notifications page switches from plain JS to JSX in the expanded view example without explanation, which can confuse new developers.
Added a sentence clarifying that the content field requires JSX components such as Box and Text, with a link to the Custom UI docs for context.
Fixes #2895
Description
Issue(s) fixed
Fixes #
Preview
Checklist
External contributor checklist
Note
Low Risk
Low risk documentation-only change that clarifies usage; no runtime behavior or APIs are modified.
Overview
Clarifies the notifications expanded-view docs by explicitly stating that the
contentfield must be authored using JSX components (e.g.,Box,Text) and links readers to the Custom UI documentation for background before following the example.Reviewed by Cursor Bugbot for commit f205c48. Bugbot is set up for automated code reviews on this repo. Configure here.