Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| - [Install and set up the Smart Accounts Kit.](../../../get-started/install.md) | ||
| - [Configure the Smart Accounts Kit.](../../configure-toolkit.md) | ||
| - [Create a session account.](../execute-on-metamask-users-behalf.md#3-set-up-a-session-account) |
There was a problem hiding this comment.
Haha, this was removed by Harrie. We are in circles, I pointed out last time during the review process. Maybe it should be updated in the style guide for the Consensys, so there's a SOT to follow.
There was a problem hiding this comment.
Ah -- sorry for the circles. I am following the Microsoft Style Guide which we refer to in our Consensys style guide: https://learn.microsoft.com/en-us/style-guide/scannable-content/lists#punctuation. It's really not a big deal either way but is autopilot for me.
There was a problem hiding this comment.
Nit: Generally periods should be outside of the linked text.
We do have examples where we don't include the punctuation as part of the link.
| ``` | ||
|
|
||
| </TabItem> | ||
| <TabItem value="Example response"> |
There was a problem hiding this comment.
default should be example.ts in the Tabs for both the changes.
There was a problem hiding this comment.
smart-accounts-kit/guides/advanced-permissions/get-granted-permissions.md
Outdated
Show resolved
Hide resolved
| ## Supported permissions table | ||
|
|
||
| The following table displays the Advanced Permissions types supported by the | ||
| Smart Accounts Kit, [MetaMask Flask](/snaps/get-started/install-flask), and MetaMask production, and the minimum version required for each. | ||
|
|
||
| If you don't see the Advanced Permissions type you're looking for, you can request it by | ||
| emailing [hellogators@consensys.net](mailto:hellogators@consensys.net). | ||
|
|
||
| | Permission type | Smart Accounts Kit | MetaMask Flask | MetaMask | | ||
| | ------------------------------------------------------------------------------------------ | ------------------ | -------------- | -------- | | ||
| | [ERC-20 periodic](use-permissions/erc20-token.md#erc-20-periodic-permission) | >= v0.1.0 | >= v13.5.0 | N/A | | ||
| | [ERC-20 stream](use-permissions/erc20-token.md#erc-20-stream-permission) | >= v0.1.0 | >= v13.5.0 | N/A | | ||
| | [ERC-20 revocation](use-permissions/erc20-token.md#erc-20-revocation-permission) | >= v0.3.0 | >= v13.14.0 | >= 13.18.1 | | ||
| | [Native token periodic](use-permissions/native-token.md#native-token-periodic-permission) | >= v0.1.0 | >= v13.5.0 | N/A | | ||
| | [Native token stream](use-permissions/native-token.md#native-token-stream-permission) | >= v0.1.0 | >= v13.5.0 | N/A | |
There was a problem hiding this comment.
We should not remove the supported advanced permissions as a page, this is not easy to find. It should have a page for itself. Maybe we can move the page under guide, but it should be a standalone
This was the feedback we got from the Hackathon.
There was a problem hiding this comment.
Would putting it as its own page under Reference > Advanced Permissions or Concepts > Advanced Permissions be suitable? It's not really a guide on its own.
| --- | ||
|
|
||
| # Use MetaMask Embedded Wallets (Web3Auth) with MetaMask Smart Accounts | ||
| # Use MetaMask Embedded Wallets with MetaMask Smart Accounts |
There was a problem hiding this comment.
This was kept by Harrie, because Embedded Wallets was not a known product name. Maybe we worth checking with @bgravenorst because EW follows the same pattern across the EW docs.
There was a problem hiding this comment.
I don't see this convention used in any EW doc headings. I wanted to remove it from the (already long) heading to clean up the page while keeping the "(Web3Auth)" in the body text.
3 participants
Description
Minor formatting, structure, and style fixes across Smart Accounts Kit docs.
Preview
https://metamask-docs-gxnfm68h9-consensys-ddffed67.vercel.app/smart-accounts-kit/development/
Checklist
External contributor checklist
Note
Low Risk
Low risk documentation-only changes, primarily rewording and reorganizing pages; main risk is broken/changed doc links due to sidebar and doc ID updates.
Overview
Cleans up Smart Accounts Kit documentation structure and wording, including sidebar reordering and removal of the
LLM contextlink, plus minor nav ordering tweaks (for example movingerror-codesanddynamicsigner placement).Consolidates Advanced Permissions docs by deleting
get-started/supported-advanced-permissions.md, moving the supported-permissions compatibility table intoguides/advanced-permissions/get-supported-permissions.md, and renaming the sidebar entry fromget-granted-advanced-permissionstoget-granted-permissions.Applies broad copy/formatting fixes across guides and troubleshooting pages (punctuation consistency, link text/capitalization, fewer inline HTML breaks), and updates an external Solana partner policy URL.
Written by Cursor Bugbot for commit 26f528a. This will update automatically on new commits. Configure here.