feat(tron-wallet-snap): route assets through Core AssetsController by ulissesferreira · Pull Request #127 · MetaMask/internal-snaps

ulissesferreira · 2026-08-05T18:23:27Z

Summary

Route asset reads through Core (getAccountAssetByID, getAccountAssetsByIDs, getAccountAssetsByScope, getAccountAssets) when migration is active
When migration is active, Core sync fetches only snap-owned (special) assets and emits AccountAssetListUpdated / AccountBalancesUpdated without local persistence
Snap keeps the full fetch + local save path while migration is off; snap-owned extraction is shared

Jira

WPN-1497
Parent: WPN-1478

Test plan

yarn workspace @metamask/tron-wallet-snap run jest --no-coverage src/services/assets/AssetsService.test.ts
yarn workspace @metamask/tron-wallet-snap run jest --no-coverage src/services/assets/snapOwnedAssets.test.ts
CI green

ulissesferreira · 2026-08-06T09:26:17Z

@cursoragent rebase with latest main

cursor · 2026-08-06T09:26:25Z

Rebased ulissesferreira/wpn-1497-core-adapter-routing-9863 onto latest main and force-pushed.

What happened during rebase:

Resolved conflict in .github/workflows/lint-build-test.yml — kept main’s upload-artifact@v7 / download-artifact@v8 (your branch had older pinned versions).
Dropped build: run workspace builds in topological-dev order — already on main.
Skipped feat(tron-wallet-snap): add Core messenger plumbing — already merged via feat(tron-wallet-snap): add Core messenger plumbing #95.

Result: 8 commits ahead of main (down from 11), including the core routing work and follow-up fixes.

PR #127 is updated: #127

ulissesferreira · 2026-08-06T12:58:36Z

@cursoragent make sure the CI is green

cursor · 2026-08-06T12:58:44Z

Taking a look!

ulissesferreira · 2026-08-06T14:11:42Z

This is how simple fetching assets will be. All calls are basically direct AssetsController calls and then, for now, we map the structure of it to minimize the amount of changes in the repository. In a future PR we will want to remove the mapping and use the structure from the AssetsController. One of the methods also returns a dictionary, purposefully, which we will refactor the existing codebase to use as well because that is the idiomatic way to do things, if you fetch by a collection of IDs it only makes sense you get them back in an easy to access way.

ulissesferreira · 2026-08-06T14:14:29Z

+      SNAPS_ASSETS_MIGRATION_FLAG_KEYS.tron,
+    );
+    return parseSnapsAssetsMigrationStage(flagValue);
+  }


We use the function from AssetsController to see which stage of the migration we are on and we simply read the feature flags from the shared RemoteFeatureFlagsProvider

ulissesferreira · 2026-08-06T14:16:11Z

        "AssetsController:getAccountAssetsByIDs",
-        "AssetsController:getAccountAssetsByScope"
+        "AssetsController:getAccountAssetsByScope",
+        "RemoteFeatureFlagController:getState"


Just a formatting fix

ulissesferreira · 2026-08-06T14:20:23Z

+    rawAmount: amount,
+    uiAmount: toUiAmount(amount, decimals).toString(),
+    iconUrl,
+  } as AssetEntity;


For now this is needed because we haven't aligned all assetType from all different places

ulissesferreira · 2026-08-06T14:21:03Z

On this file you can see the advantage of using the different adapters. Either we route operations to one or the other.

ulissesferreira · 2026-08-06T14:45:26Z

Only a rename

ulissesferreira · 2026-08-07T07:07:32Z

We were importing the configProvider directly from context.ts, which is possible to do, but we want to use dependency injection for more organized code and easier testing

taran-a · 2026-08-07T09:59:08Z

    this.cacheTtlsMilliseconds = this.#snapAdapter.cacheTtlsMilliseconds;
  }

+  async #getAssetsMigrationStage(): Promise<SnapsAssetsMigrationStage> {


nit: but might simplify a bit if we return a boolean from this method, instead of checking every time if (migrationStage === SnapsAssetsMigrationStage.Off)

taran-a · 2026-08-07T10:03:46Z

  }) {
+    this.#remoteFeatureFlagsProvider = remoteFeatureFlagsProvider;
+
    this.#snapAdapter = new SnapAssetsAdapter({


it seems like we pass all the dependencies just to instantiate SnapAssetsAdapter, maybe better to instantiate SnapAssetsAdapter outside of AssetsService and simplify this class wdyt?

Very good point and that is the correct way to implement the Adapter pattern. What is done there is not right. Will change it ✏️

taran-a · 2026-08-07T10:03:58Z

      snapClient,
+      configProvider,
+    });
+    this.#coreAdapter = new CoreAssetsAdapter({


same for CoreAssetsAdapter

taran-a

LGTM

… is on Route fungible reads and snap-owned asset sync through CoreAssetsAdapter when the Tron assets migration flag is active. Co-authored-by: Ulisses Ferreira <ulisses@hey.com>

…etsByScope Scope-scoped reads are only needed internally by CoreAssetsAdapter when aggregating account assets from Core. Co-authored-by: Ulisses Ferreira <ulisses@hey.com>

ulissesferreira · 2026-08-10T14:13:41Z

Superseded by the reorganized WPN-1497 stack:

refactor(tron-wallet-snap): extract shared asset utils and inject SnapAssetsAdapter #143
feat(tron-wallet-snap): add CoreAssetsAdapter and mapControllerAsset #144
feat(tron-wallet-snap): route asset reads through Core when migration is on #145

cursor Bot force-pushed the ulissesferreira/wpn-1497-core-adapter-routing-9863 branch from bfa488d to 327dfab Compare August 5, 2026 18:29

cursor Bot force-pushed the WPN-1497-messenger-plumbing branch 2 times, most recently from 6587ae2 to 9428a52 Compare August 5, 2026 19:34

cursor Bot force-pushed the ulissesferreira/wpn-1497-core-adapter-routing-9863 branch 2 times, most recently from 6769ec9 to 4d766ab Compare August 5, 2026 19:34

ulissesferreira changed the title ~~feat(tron-wallet-snap): route fungible reads through Core AssetsController~~ feat(tron-wallet-snap): route asset reads through Core AssetsController Aug 6, 2026

cursor Bot force-pushed the WPN-1497-messenger-plumbing branch from 9428a52 to 489bab0 Compare August 6, 2026 08:14

Base automatically changed from WPN-1497-messenger-plumbing to main August 6, 2026 08:31

cursor Bot force-pushed the ulissesferreira/wpn-1497-core-adapter-routing-9863 branch from 4d766ab to af82730 Compare August 6, 2026 09:29

ulissesferreira force-pushed the ulissesferreira/wpn-1497-core-adapter-routing-9863 branch 7 times, most recently from dbfa825 to 703eabc Compare August 6, 2026 12:39

ulissesferreira marked this pull request as ready for review August 6, 2026 12:53

ulissesferreira requested review from a team as code owners August 6, 2026 12:53

ulissesferreira temporarily deployed to default-branch August 6, 2026 12:53 — with GitHub Actions Inactive

MetaMask deleted a comment from cursor Bot Aug 6, 2026

ulissesferreira commented Aug 6, 2026

View reviewed changes

ulissesferreira force-pushed the ulissesferreira/wpn-1497-core-adapter-routing-9863 branch from 5fdb1d9 to 703eabc Compare August 6, 2026 14:15

ulissesferreira commented Aug 6, 2026

View reviewed changes

ulissesferreira force-pushed the ulissesferreira/wpn-1497-core-adapter-routing-9863 branch 2 times, most recently from d163e9c to 0bdab3a Compare August 6, 2026 14:44

ulissesferreira commented Aug 6, 2026

View reviewed changes

Comment thread packages/tron-wallet-snap/src/handlers/keyring/keyring.ts

ulissesferreira Aug 6, 2026

Copy link
Copy Markdown

Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a rename

ulissesferreira added the no-changelog label Aug 6, 2026

ulissesferreira force-pushed the ulissesferreira/wpn-1497-core-adapter-routing-9863 branch 2 times, most recently from 9c70ee3 to a793675 Compare August 6, 2026 15:06

cursor Bot force-pushed the ulissesferreira/wpn-1497-core-adapter-routing-9863 branch from a793675 to 99fa147 Compare August 6, 2026 16:34

ulissesferreira commented Aug 7, 2026

View reviewed changes

ulissesferreira force-pushed the ulissesferreira/wpn-1497-core-adapter-routing-9863 branch from 99fa147 to 00333d9 Compare August 7, 2026 07:30

gabrieledm previously approved these changes Aug 7, 2026

View reviewed changes

taran-a reviewed Aug 7, 2026

View reviewed changes

ulissesferreira dismissed gabrieledm’s stale review via b472e36 August 7, 2026 10:34

ulissesferreira force-pushed the ulissesferreira/wpn-1497-core-adapter-routing-9863 branch from 8d32e80 to b472e36 Compare August 7, 2026 10:34

taran-a previously approved these changes Aug 7, 2026

View reviewed changes

ulissesferreira dismissed taran-a’s stale review via 716c84d August 8, 2026 19:30

ulissesferreira changed the title ~~feat(tron-wallet-snap): route asset reads through Core AssetsController~~ feat(tron-wallet-snap): route assets through Core AssetsController Aug 8, 2026

ulissesferreira force-pushed the ulissesferreira/wpn-1497-core-adapter-routing-9863 branch 2 times, most recently from 193e031 to cfae0a7 Compare August 10, 2026 10:14

cursor Bot force-pushed the ulissesferreira/wpn-1497-core-adapter-routing-9863 branch from cfae0a7 to 18c7bfd Compare August 10, 2026 12:43

cursor Bot changed the base branch from main to ulissesferreira/wpn-1497-core-adapter-init-d433 August 10, 2026 12:44

cursoragent and others added 2 commits August 10, 2026 12:52

feat(tron-wallet-snap): route asset reads through Core when migration…

c39c368

… is on Route fungible reads and snap-owned asset sync through CoreAssetsAdapter when the Tron assets migration flag is active. Co-authored-by: Ulisses Ferreira <ulisses@hey.com>

refactor(tron-wallet-snap): remove unused AssetsService.getAccountAss…

c61d9b8

…etsByScope Scope-scoped reads are only needed internally by CoreAssetsAdapter when aggregating account assets from Core. Co-authored-by: Ulisses Ferreira <ulisses@hey.com>

cursor Bot force-pushed the ulissesferreira/wpn-1497-core-adapter-routing-9863 branch from 18c7bfd to c61d9b8 Compare August 10, 2026 12:52

ulissesferreira mentioned this pull request Aug 10, 2026

feat(tron-wallet-snap): route asset reads through Core when migration is on #145

Open

4 tasks

ulissesferreira closed this Aug 10, 2026

Uh oh!

Conversation

ulissesferreira commented Aug 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Jira

Test plan

Uh oh!

ulissesferreira commented Aug 6, 2026

Uh oh!

cursor Bot commented Aug 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ulissesferreira commented Aug 6, 2026

Uh oh!

cursor Bot commented Aug 6, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

taran-a Aug 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

taran-a left a comment

Choose a reason for hiding this comment

Uh oh!

ulissesferreira commented Aug 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ulissesferreira commented Aug 5, 2026 •

edited

Loading

cursor Bot commented Aug 6, 2026 •

edited

Loading

taran-a Aug 7, 2026 •

edited

Loading