fix(transaction-pay-controller): inherit isGasFeeSponsored for same-chain relay transactions#9216
Draft
matthewwalsh0 wants to merge 1 commit into
Draft
fix(transaction-pay-controller): inherit isGasFeeSponsored for same-chain relay transactions#9216matthewwalsh0 wants to merge 1 commit into
matthewwalsh0 wants to merge 1 commit into
Conversation
0d3a426 to
cd442e3
Compare
…hain Relay source fees
cd442e3 to
2347f2f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
When a parent transaction has
isGasFeeSponsored: trueand the Relay quote is same-chain (source and target chain match the parent), the TPC was not carrying that sponsorship through to either the source-network fee display or the submission options passed toTransactionController.This PR fixes that in two places:
calculateSourceNetworkCost): same-chain sponsored routes now early-return with zeroed fees andgasLimits: [0], is7702: true, skipping the full gas estimation. Sponsored transactions go through the EIP-7702 gas station hook so user-paid gas is not needed.submitViaTransactionController):isGasFeeSponsoredis now derived from the parent transaction and passed directly into bothaddTransactionandaddTransactionBatchoptions, andgasFeeTokenis suppressed when sponsored.Additionally,
skipInitialGasEstimate: trueis added to direct mUSD vault deposit submissions, which follow the same sponsored path.References
Checklist