chore: sync perps controller may 15 2026#8803
Merged
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 84a5bb6. Configure here.
geositta
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Explanation
References
Checklist
Note
Medium Risk
Touches trading readiness/signing flows and the rewards discount integration (including a DI signature change), which could affect when users are prompted to sign and how fees/discounts are computed. Most changes are additive guards/logging but in a user-critical trading path.
Overview
Improves HyperLiquid unified-account migration behavior by deferring signing-backed setup for hardware wallets across more abstraction modes, and expanding hardware keyring detection (Ledger/Trezor/OneKey/Lattice/QR) to reduce repeated signing prompts while browsing.
Hardens error classification by adding
isKeyringLockedError(walkscausechain) and using it to treat SDK-wrapped keyring-lock failures as retryable for unified-account setup, builder-fee approval, and referral setup.Updates rewards discount resolution to pass the perps builder base fee (in bips) into
getPerpsDiscountForAccount, and treatsnull(unhydrated subscription state) as “unavailable” rather than a definitive no-discount result. Adds additional error logging for failed cancel/close/TP-SL operations (including batch failure summaries).Reviewed by Cursor Bugbot for commit 84a5bb6. Bugbot is set up for automated code reviews on this repo. Configure here.