Skip to content

chore: reduce state writes from O(2n) to O(2) for NFT detection #8079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juanmigdr merged 20 commits into from
Mar 9, 2026
Merged

chore: reduce state writes from O(2n) to O(2) for NFT detection #8079

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
9db40dc
chore: reduce state writes from O(n) to O(1) for NFT detection
juanmigdr Mar 2, 2026
6030ed9
chore: minor changes
juanmigdr Mar 2, 2026
aba2797
chore: trycatch in loop
juanmigdr Mar 2, 2026
6c0d233
fix: minor bug
juanmigdr Mar 2, 2026
731ba70
Merge branch 'main' into chore/reduce-state-writes-for-nft-detection
juanmigdr Mar 2, 2026
ab57c02
chore: update assets-controllers changelog for NFT detection optimiza…
cursoragent Mar 2, 2026
c443bd7
chore: minor change
juanmigdr Mar 2, 2026
97ea630
chore: update changelog
juanmigdr Mar 2, 2026
78d4cb2
chore: throw errro when there is a real error
juanmigdr Mar 2, 2026
700a43e
chore: avoid making unecessary api calls to RPC for name and symbol i…
juanmigdr Mar 3, 2026
b79a09d
chore: avoid getting nftcontractinfo from rpc
juanmigdr Mar 9, 2026
85f67fb
Merge branch 'main' into chore/reduce-state-writes-for-nft-detection
juanmigdr Mar 9, 2026
1990baa
chore: update changelog
juanmigdr Mar 9, 2026
4a80e58
chore: minor changes impementation
juanmigdr Mar 9, 2026
5652068
chore: fix regression and add tests for it
juanmigdr Mar 9, 2026
2cc953b
chore: minor changes
juanmigdr Mar 9, 2026
dca7a96
chore: resolved comments
juanmigdr Mar 9, 2026
5358fb5
chore: updated tests
juanmigdr Mar 9, 2026
4ff84b1
Merge branch 'main' into chore/reduce-state-writes-for-nft-detection
juanmigdr Mar 9, 2026
c71e0d3
chore: minor
juanmigdr Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/assets-controllers/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed

- Optimize NFT Controller state writes from O(2n) to O(2) for NFT detection by batching contract and NFT additions ([#8079](https://github.com/MetaMask/core/pull/8079))
- Bump `@metamask/transaction-controller` from `^62.18.0` to `^62.19.0` ([#8031](https://github.com/MetaMask/core/pull/8031))

### Fixed
Expand Down
Loading
Loading