fix: correct volume rendering picking and skeleton picking interactions#172
Open
seankmartin wants to merge 1 commit into
Open
fix: correct volume rendering picking and skeleton picking interactions#172seankmartin wants to merge 1 commit into
seankmartin wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This may need further picking priority to make it work better. I'm still admittedly thinking through exactly how to do that best. But in the meantime I think this should make the picking work sometimes and give us a feel for the remaining cases that don't feel good.
Roughly the problem was that the max projection picking result gets copied over into a a picking buffer. After this, a picking pass happens for other transparent layers, and depth testing is used during that pass. The max projection picking result was being copied in with depth writing enabled, which meant that later transparent projection picking writes could get blocked by bogus depth information, instead of the real depth information they are meant to use from the opaque pass or any other depth information which may be written during the transparent pick pass.