Skip to content

feat: Add dynamic highlight color#168

Merged
seankmartin merged 7 commits into
feature/edit-modefrom
feature/NA-650
May 22, 2026
Merged

feat: Add dynamic highlight color#168
seankmartin merged 7 commits into
feature/edit-modefrom
feature/NA-650

Conversation

@afonsobspinto
Copy link
Copy Markdown
Member

@afonsobspinto afonsobspinto commented May 19, 2026

Closes https://metacell.atlassian.net/browse/NA-650

Instead of using a fixed yellow outline, the selected node outline color is now computed on the CPU from the displayed segment color and passed to the shader as uSelectedNodeOutlineColor. The implementation chooses a high-visibility highlight color from a bright palette based on contrast with the segment color

2026-05-19.15-57-51.mp4

Comment thread src/util/color.ts Outdated
Comment thread src/skeleton/frontend.ts
Comment thread src/util/color.ts Outdated
Comment thread src/skeleton/frontend.ts Outdated
@afonsobspinto afonsobspinto requested a review from seankmartin May 21, 2026 10:52
Comment thread src/skeleton/frontend.ts Outdated
Comment thread src/skeleton/frontend.ts
Comment thread src/util/color.ts Outdated
@afonsobspinto afonsobspinto requested a review from seankmartin May 22, 2026 15:20
Copy link
Copy Markdown

@seankmartin seankmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the changes on this

@seankmartin seankmartin merged commit 75ecc19 into feature/edit-mode May 22, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants