Find non-manifold vertices in parallel#6406
Merged
Merged
Conversation
Fedr
marked this pull request as ready for review
July 14, 2026 11:10
…us-chain test Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Grantim
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR,
duplicateNonManifoldVerticesinspected every vertex sequentially by walking the chains of triangles around it. Now a parallel pass classifies each vertex first, counting the chains of connected triangles around it (numChains) and the neighbor vertices passed more than once (numRepeatedVerts). The subsequent sequential pass skips every vertex where no duplication can be necessary — a single chain and no repeated neighbors, which is the vast majority in real meshes — as well as the vertices without incident triangles at all (e.g. outside of the given region).Also added a test with a vertex surrounded by both a closed ring of triangles and a separate chain, pinning the case
numChains == 2with one closed chain.