Skip to content

Find non-manifold vertices in parallel#6406

Merged
Fedr merged 12 commits into
masterfrom
parallel-find-nm
Jul 14, 2026
Merged

Find non-manifold vertices in parallel#6406
Fedr merged 12 commits into
masterfrom
parallel-find-nm

Conversation

@Fedr

@Fedr Fedr commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Before this PR, duplicateNonManifoldVertices inspected every vertex sequentially by walking the chains of triangles around it. Now a parallel pass classifies each vertex first, counting the chains of connected triangles around it (numChains) and the neighbor vertices passed more than once (numRepeatedVerts). The subsequent sequential pass skips every vertex where no duplication can be necessary — a single chain and no repeated neighbors, which is the vast majority in real meshes — as well as the vertices without incident triangles at all (e.g. outside of the given region).

Also added a test with a vertex surrounded by both a closed ring of triangles and a separate chain, pinning the case numChains == 2 with one closed chain.

@Fedr
Fedr marked this pull request as ready for review July 14, 2026 11:10
…us-chain test

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@Fedr Fedr changed the title parallel find non-manifold vertices Find non-manifold vertices in parallel Jul 14, 2026
@Fedr
Fedr merged commit 31c61dd into master Jul 14, 2026
45 checks passed
@Fedr
Fedr deleted the parallel-find-nm branch July 14, 2026 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants