fix(tests): align framework validator hint with praisonai-frameworks by MervinPraison · Pull Request #2478 · MervinPraison/PraisonAI

MervinPraison · 2026-06-30T08:57:29Z

Summary

Updates test_unknown_framework_generic_hint to expect praisonai-frameworks[...] install hints
Matches get_install_hint() behaviour after the package split (fix: update install hints to praisonai-frameworks after package split #2464)
Fixes test-core (root) failure on main and PRs like fix: address three wrapper-layer architectural gaps #2471

Test plan

pytest tests/unit/test_framework_validators.py::TestAssertFrameworkAvailableRaises::test_unknown_framework_generic_hint passes locally
test-core green on CI

Made with Cursor

Summary by CodeRabbit

Tests
- Updated a unit test to match the latest install hint shown when an unknown framework is requested.

…extra Update test_unknown_framework_generic_hint to expect praisonai-frameworks[...] after get_install_hint() switched from praisonai[...] during package split. Unblocks test-core (root) on main and open PRs. Co-authored-by: Cursor <cursoragent@cursor.com>

qodo-code-review · 2026-06-30T08:57:34Z

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

gemini-code-assist

Code Review

This pull request updates a unit test in test_framework_validators.py to assert that the error message contains 'praisonai-frameworks[some_unknown_framework_xyz]' instead of the previous 'pip install 'praisonai[some_unknown_framework_xyz]'' string. No review comments were provided, so there is no feedback to address.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

coderabbitai · 2026-06-30T08:58:18Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e09d1e19-b9be-4f40-b7c9-82b2a03c7306

📥 Commits

Reviewing files that changed from the base of the PR and between a7ca65f and 61cf52f.

📒 Files selected for processing (1)

src/praisonai/tests/unit/test_framework_validators.py

📝 Walkthrough

Walkthrough

Updates one assertion in the unit test for unknown framework names: the expected ImportError message now checks for praisonai-frameworks[some_unknown_framework_xyz] instead of pip install 'praisonai[some_unknown_framework_xyz]'.

Changes

Framework Validator Test Fix

Layer / File(s)	Summary
Unknown framework error hint assertion `src/praisonai/tests/unit/test_framework_validators.py`	Updates the expected `ImportError` message string to match the `praisonai-frameworks[...]` install hint format.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

MervinPraison/PraisonAI#2464: Updates the same test file's ImportError install-hint assertions to the praisonai-frameworks[...] format following a package split.

Suggested labels

pipeline/blocked:ci

A tiny string swap, a test kept in tune,
The install hint hops from pip to a new rune,
praisonai-frameworks now leads the way,
One line changed to keep the CI at bay,
🐇 hop hop, all assertions are okay!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title is concise and accurately reflects the test expectation update to use praisonai-frameworks install hints.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/framework-validators-hint

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

MervinPraison · 2026-06-30T08:58:25Z

@copilot Do a thorough review of this PR. Read ALL existing reviewer comments above from Qodo, Coderabbit, and Gemini first — incorporate their findings.

Review areas:

Bloat check: Are changes minimal and focused? Any unnecessary code or scope creep?
Security: Any hardcoded secrets, unsafe eval/exec, missing input validation?
Performance: Any module-level heavy imports? Hot-path regressions?
Tests: Are tests included? Do they cover the changes adequately?
Backward compat: Any public API changes without deprecation?
Code quality: DRY violations, naming conventions, error handling?
Address reviewer feedback: If Qodo, Coderabbit, or Gemini flagged valid issues, include them in your review
Suggest specific improvements with code examples where possible

greptile-apps · 2026-06-30T09:00:12Z

Greptile Summary

This PR updates the framework validator test for the split framework package. The main change is:

The unknown-framework install hint expectation now looks for praisonai-frameworks[...].
The test is aligned with the new framework package name.

Confidence Score: 5/5

The changed test looks mergeable after tightening the fallback hint assertion.

The package name expectation matches the implementation.
The fallback test no longer checks the full install command.
No runtime or security issue was found in the changed code.

src/praisonai/tests/unit/test_framework_validators.py

Important Files Changed

Filename	Overview
src/praisonai/tests/unit/test_framework_validators.py	Updates the unknown-framework validator test to expect the new `praisonai-frameworks[...]` install hint.

_{Reviews (1): Last reviewed commit: "fix(tests): align framework validator hi..." | Re-trigger Greptile}

greptile-apps · 2026-06-30T09:00:15Z

                assert_framework_available("some_unknown_framework_xyz")
            assert "some_unknown_framework_xyz" in str(exc_info.value)
-            assert "pip install 'praisonai[some_unknown_framework_xyz]'" in str(exc_info.value)
+            assert "praisonai-frameworks[some_unknown_framework_xyz]" in str(exc_info.value)


Fallback Hint Format Unchecked

When the generic fallback path returns a malformed command that still contains praisonai-frameworks[some_unknown_framework_xyz], this assertion passes even though users would not get the intended pip install '...' command. This test covers the unknown-framework fallback, so it should keep checking the full install hint format.

Suggested change

assert "praisonai-frameworks[some_unknown_framework_xyz]" in str(exc_info.value)

assert "pip install 'praisonai-frameworks[some_unknown_framework_xyz]'" in str(exc_info.value)

MervinPraison · 2026-06-30T09:08:15Z

@claude You are the FINAL architecture reviewer. If the branch is under MervinPraison/PraisonAI (not a fork), you are able to make modifications to this branch and push directly. SCOPE: Focus ONLY on Python packages (praisonaiagents, praisonai). Do NOT modify praisonai-rust or praisonai-ts. Read ALL comments above from Gemini, Qodo, CodeRabbit, and Copilot carefully before responding.

Phase 1: Review per AGENTS.md

Protocol-driven: check heavy implementations vs core SDK
Backward compatible: ensure zero feature regressions
Performance: no hot-path regressions
SDK value: review in depth whether the change genuinely adds value to the SDK — never add features for the sake of adding them. It must strengthen the SDK (simpler, more user-friendly, robust, world-class, secure). If it does not clearly add value, request changes or recommend rejecting/closing rather than merging scope creep
Do not bloat the Agent class with additional params — only if absolutely required; we already support many params.

Phase 2: FIX Valid Issues
5. For any VALID bugs or architectural flaws found by Gemini, CodeRabbit, Qodo, Copilot, or any other reviewer: implement the fix
6. Push all code fixes directly to THIS branch (do NOT create a new PR)
7. Comment a summary of exact files modified and what you skipped

Phase 3: Final Verdict
8. If all issues are resolved, approve the PR / close the Issue
9. If blocking issues remain, request changes / leave clear action items

praisonai-triage-agent · 2026-06-30T09:08:33Z

Claude finished @MervinPraison's task —— View job • claude/pr-2478-20260630-0908 • Create PR ➔

Final Architecture Review — PR #2478

Read test file and validator implementation
Verify Greptile's P2 fallback-hint concern
Fix valid issue (tighten fallback assertion)
Run tests (10 passed)
Final verdict

Phase 1 — Review per AGENTS.md

Check	Result
Protocol-driven	✅ Test-only change; protocol (`assert_framework_available`) lives in `praisonai` wrapper, no core SDK touched
Backward compatible	✅ Zero feature regressions — pure test assertion change
Performance	✅ No hot-path impact (test file only)
SDK value	✅ Strengthens test coverage; prevents silent regression in install hint
Agent class bloat	✅ N/A — `agent.py` untouched
Scope	✅ Python-only; no `praisonai-rust` / `praisonai-ts` changes

Phase 2 — Valid Issues Fixed

Greptile (P2) — valid ✅ — "Fallback Hint Format Unchecked"

The original PR weakened the assertion to a bare substring praisonai-frameworks[some_unknown_framework_xyz], which would still pass even if the surrounding pip install '...' wrapper were broken. I verified get_install_hint() returns exactly:

pip install 'praisonai-frameworks[some_unknown_framework_xyz]'

(src/praisonai/praisonai/framework_adapters/registry.py — the fallback return f"pip install 'praisonai-frameworks[{extra_name}]'").

Tightened the assertion accordingly:

# src/praisonai/tests/unit/test_framework_validators.py:84
assert "pip install 'praisonai-frameworks[some_unknown_framework_xyz]'" in str(exc_info.value)

Files modified:

src/praisonai/tests/unit/test_framework_validators.py (1 line)

Skipped (not actionable / not valid):

Gemini, Qodo, CodeRabbit, Copilot, Copilot-Greptile-summary: no actionable findings beyond the above.
CodeRabbit "Docstring Coverage" warning: not applicable to a single-line test assertion change.

Test result:

10 passed in 0.17s

(pytest src/praisonai/tests/unit/test_framework_validators.py)

Phase 3 — Final Verdict

✅ Approved. The change is minimal, focused, backward-compatible, adds genuine value (tighter regression coverage), and introduces no scope creep or security/performance concerns.

⚠️ Note: PR #2478 (fix/framework-validators-hint) is already MERGED. This follow-up fix was committed to branch claude/pr-2478-20260630-0908 and needs its own PR to land on main:

--- • Branch: claude/pr-2478-20260630-0908

gemini-code-assist Bot reviewed Jun 30, 2026

View reviewed changes

MervinPraison merged commit 0e8c346 into main Jun 30, 2026
37 checks passed

greptile-apps Bot reviewed Jun 30, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(tests): align framework validator hint with praisonai-frameworks#2478

fix(tests): align framework validator hint with praisonai-frameworks#2478
MervinPraison merged 1 commit into
mainfrom
fix/framework-validators-hint

MervinPraison commented Jun 30, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

qodo-code-review Bot commented Jun 30, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

coderabbitai Bot commented Jun 30, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

❌ Failed checks (1 warning)

Uh oh!

MervinPraison commented Jun 30, 2026

Uh oh!

Uh oh!

greptile-apps Bot commented Jun 30, 2026

Uh oh!

greptile-apps Bot Jun 30, 2026

Uh oh!

MervinPraison commented Jun 30, 2026

Uh oh!

praisonai-triage-agent Bot commented Jun 30, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

	assert "praisonai-frameworks[some_unknown_framework_xyz]" in str(exc_info.value)
	assert "pip install 'praisonai-frameworks[some_unknown_framework_xyz]'" in str(exc_info.value)

Uh oh!

Conversation

MervinPraison commented Jun 30, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Summary by CodeRabbit

Uh oh!

qodo-code-review Bot commented Jun 30, 2026

Qodo reviews are paused for this user.

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

coderabbitai Bot commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

❌ Failed checks (1 warning)

Uh oh!

MervinPraison commented Jun 30, 2026

Uh oh!

Uh oh!

greptile-apps Bot commented Jun 30, 2026

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Uh oh!

greptile-apps Bot Jun 30, 2026

Choose a reason for hiding this comment

Uh oh!

MervinPraison commented Jun 30, 2026

Uh oh!

praisonai-triage-agent Bot commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Final Architecture Review — PR #2478

Phase 1 — Review per AGENTS.md

Phase 2 — Valid Issues Fixed

Phase 3 — Final Verdict

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

MervinPraison commented Jun 30, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jun 30, 2026 •

edited

Loading

praisonai-triage-agent Bot commented Jun 30, 2026 •

edited

Loading