Skip to content

Comments

Add photo card component and update photo component#4317

Open
gabriel-bolbotina wants to merge 6 commits intomasterfrom
add-photo-card-component
Open

Add photo card component and update photo component#4317
gabriel-bolbotina wants to merge 6 commits intomasterfrom
add-photo-card-component

Conversation

@gabriel-bolbotina
Copy link
Contributor

@gabriel-bolbotina gabriel-bolbotina commented Feb 12, 2026

I created a new component called 'Photo card' which will be used instead of MMPhoto in the Form Gallery editor for features that have multiple photos.

This component has the following configurable properties:

  • image source
  • text
  • boolean value to show text or not (the logic could be replaced based on the text property)
  • height/width

To implement the blur using MultiEffects, I have modified the MMPhoto component by changing the round edged mask to use MultiEffects.

Here are some visuals:

Capture d’écran 2026-02-12 à 15 11 35
ScreenRecording_02-23-2026.14-05-08_1.mov

Also, I tested that MMPhoto behaves as before:
https://github.com/user-attachments/assets/bec5747e-c64c-475f-98e4-001456675e70

And the gallery photo page:
image

Added page with photo card component
Modified form gallery editor
Added larger cards for gallery page
@github-actions
Copy link

📦 Build Artifacts Ready

OS Status Build Info Workflow run
macOS Build 📬 Mergin Maps 63191 dmg Expires: 13/05/2026 #6319
linux Build 📬 Mergin Maps 63301 x86_64 Expires: 13/05/2026 #6330
win64 Build 📬 Mergin Maps 55121 win64 Expires: 13/05/2026 #5512
Android Build 📬 Mergin Maps 762911 APK [armeabi-v7a] Expires: 13/05/2026 #7629
Android Build 📬 Mergin Maps 762951 APK [arm64-v8a] Expires: 13/05/2026 #7629
iOS Build 📬 Build number: 26.02.857011 #8570

@github-actions
Copy link

📦 Build Artifacts Ready

OS Status Build Info Workflow run
macOS Build 📬 Mergin Maps 63211 dmg Expires: 13/05/2026 #6321
linux Build 📭 Build not yet complete or failed.
win64 Build 📬 Mergin Maps 55141 win64 Expires: 13/05/2026 #5514
Android Build 📬 Mergin Maps 763111 APK [armeabi-v7a] Expires: 13/05/2026 #7631
Android Build 📬 Mergin Maps 763151 APK [arm64-v8a] Expires: 13/05/2026 #7631
iOS Build 📬 Build number: 26.02.857211 #8572

@Withalion
Copy link
Contributor

the card footer (the blurred area) is scaled based on the card size, should we add the same logic for text size/ padding size for the text?

I would keep the state as it is, blured area size flexible and padding, text size fixed... the differences will be probably minimal and the text will fill out the spare space if necessary

@gabriel-bolbotina gabriel-bolbotina marked this pull request as ready for review February 16, 2026 07:49
Added size property
Modified text padding to adapt to the size
Added photo card in gallery that adapts to the width
@github-actions
Copy link

📦 Build Artifacts Ready

OS Status Build Info Workflow run
macOS Build 📬 Mergin Maps 63661 dmg Expires: 18/05/2026 #6366
linux Build 📭 Build not yet complete or failed.
win64 Build 📬 Mergin Maps 55611 win64 Expires: 18/05/2026 #5561
Android Build 📬 Mergin Maps 767651 APK [arm64-v8a] Expires: 18/05/2026 #7676
Android Build 📬 Mergin Maps 767611 APK [armeabi-v7a] Expires: 18/05/2026 #7676
iOS Build 📭 Build not yet complete or failed.

@Withalion Withalion linked an issue Feb 23, 2026 that may be closed by this pull request
@gabriel-bolbotina gabriel-bolbotina changed the title Add photo card component Add photo card component and update photo component Feb 23, 2026
Copy link
Contributor

@Withalion Withalion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plus the comments about components I wrote to you.

It would be nice for our reference to note down in MMPhoto (probably) what made the mask work.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why we copied the whole file into gallery and didn't reuse MMFormPhotoViewer from the app (which was specifically made for this use case) ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the original MMFormViewer has the photoSketchingLoader and other dependencies were required for this to work. I think we can park the topic of testing the photo sketching in the gallery app, and just keep it a visual tool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1-N relation not showing display text

3 participants