Skip to content

docs(configuration): fix reference accuracy and style drift#12205

Open
jd wants to merge 1 commit into
mainfrom
devs/jd/jd/mrgfy-8212-docs-health-non-deterministic-audit-loop-style-accuracy/fix-ref-accuracy-style-drift--a5524167
Open

docs(configuration): fix reference accuracy and style drift#12205
jd wants to merge 1 commit into
mainfrom
devs/jd/jd/mrgfy-8212-docs-health-non-deterministic-audit-loop-style-accuracy/fix-ref-accuracy-style-drift--a5524167

Conversation

@jd

@jd jd commented Jul 26, 2026

Copy link
Copy Markdown
Member

First docs-health audit pass over the configuration reference pages. Accuracy
fixes verified against the config JSON schema and the engine source:

  • conditions: add check-cancelled to the attributes supporting the
    qualified @app/check form (engine CHECK_ATTRIBUTES includes it)
  • data-types: remove the nonexistent "week" duration unit (engine accepts
    only days/hours/minutes/seconds)
  • sharing: the extends-merge caution now lists all dict-merged keys
    (merge_queue and merge_protections_settings were missing); close the
    caution directive that never closed (inline :::)
  • file-format: add the missing scopes top-level key; fix the anchor to
    extending-configuration-files (heading lives on /configuration/sharing)
  • data-types: make the Jinja2 deprecation notice dateless per the repo rule
  • sharing: fix functionnal typo in an example check name

Plus a conservative style pass per the proofread rubrics: banned words,
prose em dashes, throat-clearing intros, and ~15 grammar fixes.

Part of the first manual docs-health audit (MRGFY-8212).

Co-Authored-By: Claude Fable 5 noreply@anthropic.com

Copilot AI review requested due to automatic review settings July 26, 2026 08:14
@mergify
mergify Bot had a problem deploying to Mergify Merge Protections July 26, 2026 08:14 Failure
@jd

jd commented Jul 26, 2026

Copy link
Copy Markdown
Member Author

This pull request is part of a Mergify stack:

# Pull Request Link
1 docs(configuration): fix reference accuracy and style drift #12205 👈
2 docs(workflow): fix action reference accuracy and style drift #12206
3 docs(merge-queue): fix accuracy drift and style across the section #12207
4 docs(commands,merge-protections,migrate): fix broken examples and style #12208
5 docs(ci-insights,test-insights,monorepo-ci): fix wrong commands and claims #12209
6 docs(stacks,integrations,cli,api): fix CLI and integration inaccuracies #12210
7 docs(enterprise,misc): fix inverted Redis TLS instructions and style #12211

@mergify

mergify Bot commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Merge Protections

🔴 2 of 6 protections blocking · waiting on 👀 reviews

Protection Waiting on
🔴 👀 Review Requirements 👀 reviews
🔴 🔎 Reviews 👀 reviews
🟢 🤖 Continuous Integration
🟢 Enforce conventional commit
🟢 📕 PR description
🟢 🚦 Auto-queue

🔴 👀 Review Requirements

Waiting for

  • #approved-reviews-by >= 2
This rule is failing.
  • any of:
    • #approved-reviews-by >= 2
    • author = dependabot[bot]
    • author = mergify-ci-bot

🔴 🔎 Reviews

Waiting for

  • #review-requested = 0
This rule is failing.
  • #review-requested = 0
  • #changes-requested-reviews-by = 0
  • #review-threads-unresolved = 0

Show 4 satisfied protections

🟢 🤖 Continuous Integration

  • all of:
    • check-success = build
    • check-success = lint
    • check-success = test
    • any of:
      • check-success = test-broken-links
      • label = ignore-broken-links
    • any of:
      • check-success=Cloudflare Pages
      • -head-repo-full-name~=^Mergifyio/

🟢 Enforce conventional commit

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|internal|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?!?:

🟢 📕 PR description

  • body ~= (?ms:.{48,})

🟢 🚦 Auto-queue

When all merge protections are satisfied, this pull request will be queued automatically.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR performs an accuracy + style cleanup pass across several configuration reference pages, aligning content with the config schema/engine behavior and reducing prose/style drift.

Changes:

  • Updates configuration docs for correctness (e.g., supported check-* qualifiers, valid duration units, merged keys in extends cautions).
  • Fixes broken/incorrect links and closes an unclosed MDX caution directive.
  • Applies a conservative style/grammar pass and corrects a typo in an example check name.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
src/content/docs/configuration/sharing.mdx Refines intro prose, fixes an example typo, and corrects/finishes the extends merging caution block.
src/content/docs/configuration/file-format.mdx Improves introductory wording, fixes the extends link target, and documents the missing scopes top-level key.
src/content/docs/configuration/data-types.mdx Removes nonexistent duration unit (“week”), makes the Jinja2 deprecation notice dateless, and applies multiple phrasing/grammar fixes.
src/content/docs/configuration/conditions.mdx Fixes a broken anchor link and updates supported qualified @app/check attributes (adds check-cancelled) plus minor wording fix.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/content/docs/configuration/file-format.mdx Outdated
Comment thread src/content/docs/configuration/conditions.mdx Outdated
@jd
jd marked this pull request as ready for review July 26, 2026 08:19
@mergify
mergify Bot requested a review from a team July 26, 2026 08:19
First docs-health audit pass over the configuration reference pages. Accuracy
fixes verified against the config JSON schema and the engine source:

- conditions: add `check-cancelled` to the attributes supporting the
  qualified `@app/check` form (engine CHECK_ATTRIBUTES includes it)
- data-types: remove the nonexistent "week" duration unit (engine accepts
  only days/hours/minutes/seconds)
- sharing: the extends-merge caution now lists all dict-merged keys
  (`merge_queue` and `merge_protections_settings` were missing); close the
  caution directive that never closed (inline `:::`)
- file-format: add the missing `scopes` top-level key; fix the anchor to
  extending-configuration-files (heading lives on /configuration/sharing)
- data-types: make the Jinja2 deprecation notice dateless per the repo rule
- sharing: fix `functionnal` typo in an example check name

Plus a conservative style pass per the proofread rubrics: banned words,
prose em dashes, throat-clearing intros, and ~15 grammar fixes.

Part of the first manual docs-health audit (MRGFY-8212).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Change-Id: Ia552416708bfdbb4d6fe882084bc3d234cdddb5a
@jd
jd force-pushed the devs/jd/jd/mrgfy-8212-docs-health-non-deterministic-audit-loop-style-accuracy/fix-ref-accuracy-style-drift--a5524167 branch from 23a05f1 to 3b32271 Compare July 26, 2026 08:23
@jd

jd commented Jul 26, 2026

Copy link
Copy Markdown
Member Author

Revision history

# Type Changes Reason Date
1 initial 23a05f1 2026-07-26 08:22 UTC
2 content 23a05f1 → 3b32271 address Copilot review: link the scopes key like its siblings in the top-level key list; use 'less than' instead of 'lesser than' in the operator table (labels and prose) 2026-07-26 08:22 UTC

@mergify
mergify Bot had a problem deploying to Mergify Merge Protections July 26, 2026 08:23 Failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants