This repository was archived by the owner on Nov 28, 2023. It is now read-only.
Remove use of multiprocessing to fix #54#55
Open
mmurdoch wants to merge 1 commit intoMeltwaterArchive:masterfrom
Open
Remove use of multiprocessing to fix #54#55mmurdoch wants to merge 1 commit intoMeltwaterArchive:masterfrom
mmurdoch wants to merge 1 commit intoMeltwaterArchive:masterfrom
Conversation
Author
|
I've also successfully tested this fix on Debian 8.0 (jessie) - Python 2.7.9. |
Author
|
Tested this fix on Debian 8.0 (jessie) - Python 3.4.3 (although this is currently blocked by issue #56). |
Contributor
|
Thanks for the PR addressing this, we'll review and merge in the next few days once we've looked into what's causing the current test failures and addressed those. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing the creation of a child process for Unix systems (making them consistent with the approach on Windows) allows twisted to handle Ctrl+C to shut down live stream processing cleanly.
Tested on Mac OS X (Yosemite).