feat: Use SSL and SSH config in LOG_BASED replication#717
Merged
edgarrmondragon merged 13 commits intoMeltanoLabs:mainfrom Jan 13, 2026
Merged
feat: Use SSL and SSH config in LOG_BASED replication#717edgarrmondragon merged 13 commits intoMeltanoLabs:mainfrom
edgarrmondragon merged 13 commits intoMeltanoLabs:mainfrom
Conversation
danilofuchs
commented
Jan 12, 2026
Member
edgarrmondragon
left a comment
There was a problem hiding this comment.
Thanks @danilofuchs! Just one small nit.
edgarrmondragon
added a commit
that referenced
this pull request
Jan 13, 2026
…nd port - Bug introduced by #717 Signed-off-by: Edgar Ramírez Mondragón <edgarrm358@gmail.com>
edgarrmondragon
added a commit
that referenced
this pull request
Jan 13, 2026
…nd port - Bug introduced by #717 Signed-off-by: Edgar Ramírez Mondragón <edgarrm358@gmail.com>
edgarrmondragon
added a commit
that referenced
this pull request
Jan 14, 2026
…nd port - Bug introduced by #717 Signed-off-by: Edgar Ramírez Mondragón <edgarrm358@gmail.com>
edgarrmondragon
added a commit
that referenced
this pull request
Jan 14, 2026
…and port - Bug introduced by #717 Signed-off-by: Edgar Ramírez Mondragón <edgarrm358@gmail.com>
edgarrmondragon
added a commit
that referenced
this pull request
Jan 14, 2026
…nd port (#721) - I missed this when reviewing #717 - #469 cc @danilofuchs Signed-off-by: Edgar Ramírez Mondragón <edgarrm358@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #469
Problem
There are two libraries used for connecting to the PostgreSQL database, depending on the replication mode:
FULL_TABLEandINCREMENTAL: SQLAlchemy + psycopg2LOG_BASED: psycopg2 directlyThe SQLAlchemy URL takes into account SSL and SSH configuration options, but the psycopg2 connection uses the raw config values.
Another inconsistency is that
application_name=tap-postgresis only set if using the psycopg2 connection.Solution
Creating a shared
ConnectionParametersdataclass which can be built via either discrete config parameters, or via asqlalchemy_urlconfig. This dataclass can then be rendered as either a SQLAlchemy or a psycopg2 URLThe
PostgresLogBasedStreamuses the exact sameConnectionParametersas the other streams, via their sharedPostgresConnectorNote: I opted to now allow configuring log_based replication with the
sqlalchemy_urlconfig, for more flexibilityQuestions
Future improvements
postgres_options, to allow adding arbitrary PostgreSQL options without bailing out tosqlalchemy_urlapplication_namevia tap options, perhaps via the above suggested option