Add dependents count fields on repositories stream#37
Closed
laurentS wants to merge 1 commit intoMeltanoLabs:mainfrom
Closed
Add dependents count fields on repositories stream#37laurentS wants to merge 1 commit intoMeltanoLabs:mainfrom
laurentS wants to merge 1 commit intoMeltanoLabs:mainfrom
Conversation
This is WIP, as this commit requires changes in the SDK which are in a separate PR on that repo.
Contributor
|
I agree with @aaronsteers that adding this as a stream will make it easier and not require the MR on the SDk. How about 3 streams @laurentS:
Have a look at their implementation: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is WIP, as this commit requires changes in the SDK which are in a separate PR on that repo. Closes #34
@aaronsteers following our conversation on the issue, I've taken a stab at this.
selected_by_defaulttoProperty. I thought setting this tofalsefor the 2 extra fields would prevent users from getting this extra data unless they explicitly ask for it by settingselected: truein the catalog.