Improve query editor execution and autocomplete input - #305
Merged
Conversation
Maxteabag
force-pushed
the
fix/issue-299-input-and-tabs
branch
from
August 23, 2026 15:32
d082565 to
f0846fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
autocomplete_acceptto EnterWhy
GNOME Terminal on Pop!_OS 22 uses the legacy terminal keyboard encoding where Ctrl+Enter and Enter are both sent as carriage return (
^M). Sqlit cannot recover a modifier the terminal does not transmit. This PR does not add another execution shortcut; it instead ensures configured insert-mode actions are routed correctly on terminals that can report them.Autocomplete handling is binding-aware: the default remains Tab and ordinary Enter remains a newline, while an explicit Enter autocomplete binding works as configured.
Partially addresses #299. Query tabs are deliberately excluded because they are separate product/lifecycle scope.
Validation
pilot.press()coverage for Ctrl+Enter, Enter, and Tabpilot.click()coverage for choosing a suggestion