Fix textual-fastdatatable 0.19 rendering compatibility - #303
Merged
Conversation
Maxteabag
force-pushed
the
fix/issue-301-max-width
branch
from
August 23, 2026 15:34
e514215 to
7a93b78
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
max_widthargument passed by textual-fastdatatable 0.19Root cause
sqlit-tuipreviously allowedtextual-fastdatatable>=0.14.0. Version 0.19.0 added amax_widthkeyword to_get_cell_renderable(), butSqlitDataTablestill overrode the earlier two-argument signature. Fresh installs or dependency upgrades resolving 0.19 therefore raisedTypeErrorwhile rendering result cells.Because sqlit integrates with a protected FastDataTable hook and the dependency is still pre-1.0, upgrades are now explicit and test-gated instead of floating automatically.
Fixes #301.
Validation