Skip to content

Fix textual-fastdatatable 0.19 rendering compatibility - #303

Merged
Maxteabag merged 2 commits into
mainfrom
fix/issue-301-max-width
Aug 23, 2026
Merged

Fix textual-fastdatatable 0.19 rendering compatibility#303
Maxteabag merged 2 commits into
mainfrom
fix/issue-301-max-width

Conversation

@Maxteabag

@Maxteabag Maxteabag commented Aug 23, 2026

Copy link
Copy Markdown
Owner

Summary

  • accept the new optional max_width argument passed by textual-fastdatatable 0.19
  • pin textual-fastdatatable exactly to 0.19.0 so untested releases cannot silently break fresh installations
  • refresh the lockfile for the pinned dependency and its Textual requirement
  • add a regression that exercises both the overridden hook and a mounted table render

Root cause

sqlit-tui previously allowed textual-fastdatatable>=0.14.0. Version 0.19.0 added a max_width keyword to _get_cell_renderable(), but SqlitDataTable still overrode the earlier two-argument signature. Fresh installs or dependency upgrades resolving 0.19 therefore raised TypeError while rendering result cells.

Because sqlit integrates with a protected FastDataTable hook and the dependency is still pre-1.0, upgrades are now explicit and test-gated instead of floating automatically.

Fixes #301.

Validation

  • focused compatibility/blob tests: 4 passed
  • full UI suite: 302 passed
  • exact 0.19.0 environment verified
  • Ruff and structured autoreview: clean

@Maxteabag
Maxteabag force-pushed the fix/issue-301-max-width branch from e514215 to 7a93b78 Compare August 23, 2026 15:34
@Maxteabag
Maxteabag merged commit 3451adf into main Aug 23, 2026
11 checks passed
@Maxteabag
Maxteabag deleted the fix/issue-301-max-width branch August 23, 2026 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"unexpected keyword argument 'max_width'" when trying to select

1 participant