fix: Add database/schema for update and delete queries#250
Merged
Maxteabag merged 5 commits intoJun 3, 2026
Conversation
…te-query-qualified-name
Drives the real action_delete_row / action_edit_cell against a SQL Server with two databases. With the old bare-table-name query the statements hit the connection's current database instead of the table's own; this asserts the qualified name targets the correct database. Skips when no server.
Owner
|
Thanks for the fix! |
Owner
|
I don't think we need the "build_select_query" refactoring. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you use
updateanddeletefrom the result panel - it doesn't include database/schema. This PR should add them.I've tried to not include them if they are not needed.
self.supports_cross_database_queriesis trueself.default_schemaand if database qualifier hasn't already been added. ([db].[users]doesn't work, has to be[db].[dbo].[users])Locally I've also updated the
build_select_queryon all providers to usequalified_name. It still needs some testing, but it simplifies the functions a lot. Would you like a PR with that as well?