-
Notifications
You must be signed in to change notification settings - Fork 0
release/v5.2.0 #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release/v5.2.0 #33
Conversation
code-crusher
commented
Jan 14, 2026
- release axon-code-2 model out of preview + default mdoel
- fixes to default model
- complete memories feature
- complete memories feature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧪 PR Review is completed: The update to axon-code-2 is consistent. However, there is a critical bug in MemoryManager regarding stateful Regex usage, and several debug console.log statements have been left in the production code which should be removed.
Skipped files
CHANGELOG.md: Skipped file patternREADME.md: Skipped file patterncli/docs/PROVIDER_CONFIGURATION.md: Skipped file patternsrc/package.nls.json: Skipped file patternwebview-ui/src/i18n/locales/en/memories.json: Skipped file pattern
⬇️ Low Priority Suggestions (4)
src/core/assistant-message/AssistantMessageParser.ts (1 suggestion)
Location:
src/core/assistant-message/AssistantMessageParser.ts(Lines 80-88)🟡 Code Quality
Issue: Debug
console.logstatement left in production code.Fix: Remove the logging statement.
Impact: Reduces log noise in production
- console.log( - `[AssistantMessageParser] Processing ${toolCalls.length} native tool call(s):`, - toolCalls.map((tc) => ({ - id: tc.id, - index: tc.index, - name: tc.function?.name, - argsLength: tc.function?.arguments?.length, - })), - ) +
src/core/task/Task.ts (3 suggestions)
Location:
src/core/task/Task.ts(Lines 2266-2268)🟡 Code Quality
Issue: Debug
console.logstatement left in production code.Fix: Remove the logging statement.
Impact: Reduces log noise
- console.log( - `[Task] Received native_tool_calls chunk with ${chunk.toolCalls.length} tool call(s)`, - ) +Location:
src/core/task/Task.ts(Lines 2276-2278)🟡 Code Quality
Issue: Debug
console.logstatement left in production code.Fix: Remove the logging statement.
Impact: Reduces log noise
- console.log( - `[Task] After processing: yielded ${yieldedCount} tool uses, contentBlocks before: ${this.assistantMessageContent.length}`, - ) +Location:
src/core/task/Task.ts(Lines 2283-2285)🟡 Code Quality
Issue: Debug
console.logstatement left in production code.Fix: Remove the logging statement.
Impact: Reduces log noise
- console.log( - `[Task] contentBlocks after: ${this.assistantMessageContent.length}, prevLength: ${prevLength}`, - ) +
| const { regex, workspace, limit = DEFAULT_SEARCH_LIMIT } = options | ||
|
|
||
| try { | ||
| const regexPattern = new RegExp(regex, "gi") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟠 Logic Error
Issue: Using the global g flag with new RegExp makes the regex stateful. The lastIndex property is updated after each match, causing subsequent test() calls on different strings to fail unpredictably (e.g., skipping every second match).
Fix: Remove the g flag. The i flag is sufficient for case-insensitive matching.
Impact: Prevents the search functionality from missing valid memories
| const regexPattern = new RegExp(regex, "gi") | |
| const regexPattern = new RegExp(regex, "i") |
| // Log to help diagnose parsing issues | ||
| console.log( | ||
| `[AssistantMessageParser] JSON parsing incomplete/failed for tool "${accumulatedCall.function!.name}" (id: ${toolCallId}). Args length: ${accumulatedCall.function!.arguments.length}. Error:`, | ||
| error, | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Code Quality
Issue: Debug console.log statement left in production code. This is inside a loop processing chunks and will be very spammy.
Fix: Remove the logging statement.
Impact: Prevents console spam during streaming
| // Log to help diagnose parsing issues | |
| console.log( | |
| `[AssistantMessageParser] JSON parsing incomplete/failed for tool "${accumulatedCall.function!.name}" (id: ${toolCallId}). Args length: ${accumulatedCall.function!.arguments.length}. Error:`, | |
| error, | |
| ) |
|
✅ Reviewed the changes: Verified removal of debug logging statements in |