Make the list of global elements non recursive#283
Open
robUx4 wants to merge 5 commits intoMatroska-Org:masterfrom
Open
Make the list of global elements non recursive#283robUx4 wants to merge 5 commits intoMatroska-Org:masterfrom
robUx4 wants to merge 5 commits intoMatroska-Org:masterfrom
Conversation
We should be skipping data with the actual EbmlSemanticContext of that element.
No other code was executed after bEndFound was set to true to exist the loop.
We may find an upper level element in an unknown length master element. We skip its data as well, until there's nothing to skip. This is very suspicious.
We don't need to use the global context that contains the list of global elements. The global element cannot be a have an unknown size and will just skip the data and return nullptr.
Either the global element needs to be found in the list of elements, or though the callback. If the extra callback points to itself we may loop recursively on it.
mbunkus
requested changes
Mar 2, 2024
Contributor
mbunkus
left a comment
mbunkus
left a comment
There was a problem hiding this comment.
mkvextract segfaults when reading certain files with these changes. There seems to be an infinite recursion happening with EbmlElement::SkipData() calling itself directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And rework the skipping of unknown/infinite length master elements.
With a bit more comments it's clearer what each part does. The handling of going to a parent level seems bogus.