Revise render/latex.py and render/text.py for box attributes#1677
Merged
Revise render/latex.py and render/text.py for box attributes#1677
render/latex.py and render/text.py for box attributes#1677Conversation
Member
Author
|
These changes are now pretty straightforward. However, in making the changes, I see that there is a bit of duplication across the form rendering that can be eliminated and simplified. We could add this to this PR, but I'm thinking another smallish PR for DRYing the code. Also in the grand scheme of things, there is removing hard-coding characters, and related to that, whether some of the code that does this can't be directed more by table properties from YAML files. @mmatera: your thoughts? |
Contributor
|
As you prefer. Any of these changes should be too disturbing to the existing prs |
Member
Author
We will merge an interate then. |
rocky
changed the title
rocky
changed the title
render/latex.py and render/text.py for box attributes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revise render/latex.py and render/text.py for box attributes