!F Adding gifski gif converter#483
Draft
pr8x wants to merge 1 commit intoMathewSachin:masterfrom
Draft
Conversation
Owner
|
Looks good so far. |
Author
|
Hi I am currently quite busy with work so If anybody wants to actually fork this and add some option to download gifski in the settings... That would be cool! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a working draft of integrating gifski into Captura. Things to consider:
GifskiOptions. The exe path is hardcoded at the moment.--qualityand--fpsoption and/or downsample resolution (suboptimal). The USP of gifski is quality not compression, so we shouldn't expect too much.Captura.FFmpeg, most useCaptura.Models). I think that should be fixed. Ideally, they should reside in a namespace named like the project/folder IMO.Fixed issues: #457