<fix>[storage]: ZSTAC-81222 defer referenced reimage trash - #4675
<fix>[storage]: ZSTAC-81222 defer referenced reimage trash#4675ZStack-Robot wants to merge 1 commit into
Conversation
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 39 minutes Limit details: You’ve used all 1 included review currently available under your plan. You completed 89 included PR reviews in the past 7 days; at that activity level, included reviews refill at 1 review per hour. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
Warning
|
864b115 to
d813918
Compare
Keep an old root out of reimage trash while downstream snapshot references still depend on it. Distinguish the reimage old root by rootInstallUrl during reference cleanup. After the last downstream reference disappears, delete the chain once from leaf to root, sync capacity, and remove matching legacy reimage trash. Resolves: ZSTAC-81222 Change-Id: I500146d6898405f4df0cc18a1d8a4aaa94fee49d
d813918 to
f2001fe
Compare
| " and tree.uuid = :treeUuid" + | ||
| " and vol.primaryStorageUuid = tree.primaryStorageUuid", String.class) | ||
| " and vol.primaryStorageUuid = tree.primaryStorageUuid" + | ||
| " and vol.installPath = tree.rootInstallUrl", String.class) |
There was a problem hiding this comment.
Comment from jin.ma:
delete in db ，不是 delete in 数据面
| return controller.reportCapabilities().getSnapshotCapability() | ||
| .getPlacementType() != VolumeSnapshotCapability.VolumeSnapshotPlacementType.INTERNAL; | ||
| .getPlacementType() != VolumeSnapshotCapability.VolumeSnapshotPlacementType.INTERNAL | ||
| || VolumeSnapshotReferenceUtils.isVolumeDirectlyReferenceByOthers(msg.getVolume()); |
There was a problem hiding this comment.
Comment from haidong.pang:
bug现场，没有判断 old-root 在树上是否还有子节点。
flow "delete-origin-root-volume-which-has-no-snapshot"
│
有别的卷在引用 P_old 上的快照？
│
┌─────────────────┴─────────────────┐
否 是
│ │
trashVolume(P_old) skip，什么都不做
│ │
trash 回收真删 P_old P_old 原样留在数据面
│ │
✗ 下游 child 卷的 backing 断了 ✓ 下游链完好，等 child 删除时再收
2 participants
Summary
Keep the old root volume out of trash while linked-clone children still depend on its snapshot chain. Transfer cleanup ownership to the existing trash/GC path after the last reference is removed.
Changes
ReimageVolumetrash creation while downstream references exist.Testing
mvn -pl storage -am -Dmaven.test.skip=true compileResolves: ZSTAC-81222
sync from gitlab !10704