<fix>[volume-cache]: pass cache devices on delete#4430
Conversation
Add cache devices to DeletePoolCmd so the host cache agent can remove its LVM filter allowlist entries after deleting a pool. Resolves: ZSTAC-85952 Change-Id: I3d8c9c5b7e6f4a2d1c0b9a887766554433221100
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 49 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: http://open.zstack.ai:20001/code-reviews/zstack-cloud.yaml (via .coderabbit.yaml) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Summary
Resolves: ZSTAC-85952
Add cache device paths to
DeletePoolCmdso HostCacheStore can send persisted devices to kvmagent delete operations for exact LVM filter cleanup.Changes
devicestoKVMAgentCommands.DeletePoolCmd.ConnectPoolCmdunchanged; connect/reconnect no longer appends LVM filter entries.Testing
git -C zstack diff --check upstream/5.5.28..HEADZSTACK_MAVEN_CACHE_FULL_BUILD_THRESHOLD=0 rtk scripts/backend-build-container/container-run --base 5.5.28 --mr zstack:10388 --mr premium:14558 --mr zstack-utility:7417 test-premium --package premium/test-premium HostCacheStoreLifecycleCaseRelated MRs
sync from gitlab !10392