Skip to content

<fix>[volume-cache]: pass cache devices on delete#4430

Open
MatheMatrix wants to merge 1 commit into
5.5.28from
sync/haidong.pang/codex/zstac-85952-host-cache-store-lvm-filter@@3
Open

<fix>[volume-cache]: pass cache devices on delete#4430
MatheMatrix wants to merge 1 commit into
5.5.28from
sync/haidong.pang/codex/zstac-85952-host-cache-store-lvm-filter@@3

Conversation

@MatheMatrix

Copy link
Copy Markdown
Owner

Summary

Resolves: ZSTAC-85952

Add cache device paths to DeletePoolCmd so HostCacheStore can send persisted devices to kvmagent delete operations for exact LVM filter cleanup.

Changes

  • Add devices to KVMAgentCommands.DeletePoolCmd.
  • Keep ConnectPoolCmd unchanged; connect/reconnect no longer appends LVM filter entries.

Testing

  • git -C zstack diff --check upstream/5.5.28..HEAD
  • ZSTACK_MAVEN_CACHE_FULL_BUILD_THRESHOLD=0 rtk scripts/backend-build-container/container-run --base 5.5.28 --mr zstack:10388 --mr premium:14558 --mr zstack-utility:7417 test-premium --package premium/test-premium HostCacheStoreLifecycleCase

Related MRs

  • premium: pending new MR
  • zstack-utility: pending new MR

sync from gitlab !10392

Add cache devices to DeletePoolCmd so the host cache agent can remove its LVM filter allowlist entries after deleting a pool.

Resolves: ZSTAC-85952

Change-Id: I3d8c9c5b7e6f4a2d1c0b9a887766554433221100
@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 49 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: http://open.zstack.ai:20001/code-reviews/zstack-cloud.yaml (via .coderabbit.yaml)

Review profile: CHILL

Plan: Pro

Run ID: 7b28cd1c-69a3-48c9-b88f-522111c14bcf

📥 Commits

Reviewing files that changed from the base of the PR and between d22b42d and d33fb6e.

📒 Files selected for processing (1)
  • plugin/kvm/src/main/java/org/zstack/kvm/KVMAgentCommands.java
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sync/haidong.pang/codex/zstac-85952-host-cache-store-lvm-filter@@3

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant