Skip to content

<feature>[host]: revert CPU core license backport#4422

Closed
ZStack-Robot wants to merge 1 commit into
4.8.38from
sync/hanyu.liang/fix-78594-revert@@3
Closed

<feature>[host]: revert CPU core license backport#4422
ZStack-Robot wants to merge 1 commit into
4.8.38from
sync/hanyu.liang/fix-78594-revert@@3

Conversation

@ZStack-Robot

Copy link
Copy Markdown
Collaborator

Jira: http://jira.zstack.io/browse/ZSTAC-78594

Root cause:

  • ZSTAC-78594 was backported to 4.8.38 through zstack MR 10001.
  • The request is to revert the patch submitted in this Jira from 4.8.38.
  • Because this Jira changes zstack, premium, and zstack-utility together, the corrected source branch uses suffix @@3.

Fix summary:

  • Revert zstack MR 10001 on top of current 4.8.38.
  • Remove cpuCoreNum host capacity reporting, HostCapacityVO/API/SDK fields, and the V4.8.38 upgrade SQL entries introduced by the backport.
  • Keep later 4.8.38 upgrade SQL changes in the same file.

Verification:

  • git diff --check HEAD~1..HEAD
  • rg -n '^(<{7}|={7}$|>{7})'
  • rg -n 'cpuCoreNum|LICENSE_QUOTA_TYPE_CPU_CORE|CPU_CORE_NUM|corenum'
  • Compile and cases were not run per original request for revert MR.

Logs:

  • N/A, no build or case requested for zstack revert MR.

Original MR:

Supersedes:

sync from gitlab !10384

Revert the 4.8.38 backport from zstack MR 10001.

Remove cpuCoreNum capacity reporting and related schema/API fields.

DBImpact

Resolves: ZSTAC-78594

Change-Id: I6440ef9d120bfc73c3c25c9713f4bfb7dd03ae24
@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 51 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: e79f9be2-5363-4862-bf91-4716944b886b

📥 Commits

Reviewing files that changed from the base of the PR and between e95ecdc and abd409f.

📒 Files selected for processing (11)
  • compute/src/main/java/org/zstack/compute/allocator/HostAllocatorManagerImpl.java
  • conf/db/upgrade/V4.8.38__schema.sql
  • header/src/main/java/org/zstack/header/allocator/HostCapacityInventory.java
  • header/src/main/java/org/zstack/header/allocator/HostCapacityVO.java
  • header/src/main/java/org/zstack/header/allocator/HostCapacityVO_.java
  • header/src/main/java/org/zstack/header/cluster/ReportHostCapacityMessage.java
  • plugin/kvm/src/main/java/org/zstack/kvm/KVMAgentCommands.java
  • plugin/kvm/src/main/java/org/zstack/kvm/KVMHost.java
  • sdk/src/main/java/org/zstack/sdk/LicenseInventory.java
  • sdk/src/main/java/org/zstack/sdk/license/api/server/RequestLicenseCapacityAction.java
  • test/src/test/groovy/org/zstack/test/integration/kvm/capacity/CheckHostCapacityWhenAddHostCase.groovy
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sync/hanyu.liang/fix-78594-revert@@3

Comment @coderabbitai help to get the list of available commands.

@zstack-robot-2 zstack-robot-2 deleted the sync/hanyu.liang/fix-78594-revert@@3 branch July 3, 2026 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants