Skip to content

<fix>[port-forwarding]: avoid stale binding on invalid nic attach #4416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ZStack-Robot wants to merge 1 commit into from
Closed

<fix>[port-forwarding]: avoid stale binding on invalid nic attach #4416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
109 changes: 92 additions & 17 deletions ...ng/src/main/java/org/zstack/network/service/portforwarding/PortForwardingManagerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
import org.zstack.header.core.NopeCompletion;
import org.zstack.header.core.workflow.*;
import org.zstack.header.errorcode.ErrorCode;
import org.zstack.header.errorcode.OperationFailureException;
import org.zstack.header.errorcode.SysErrors;
import org.zstack.header.exception.CloudRuntimeException;
import org.zstack.header.identity.APIChangeResourceOwnerMsg;
Expand Down Expand Up @@ -404,8 +405,16 @@ private void handle(APIDetachPortForwardingRuleMsg msg) {
PortForwardingRuleInventory inv = PortForwardingRuleInventory.valueOf(vo);
final PortForwardingStruct struct = makePortForwardingStruct(inv);
struct.setReleaseVmNicInfoWhenDetaching(true);
final NetworkServiceProviderType providerType = nwServiceMgr.getTypeOfNetworkServiceProviderForService(struct.getGuestL3Network().getUuid(),
NetworkServiceType.PortForwarding);
final NetworkServiceProviderType providerType = getPortForwardingProviderTypeIfEnabled(struct.getGuestL3Network().getUuid());
if (providerType == null) {
logger.warn(String.format("port forwarding rule[uuid:%s] is attached to vm nic[uuid:%s] on L3[uuid:%s] without PortForwarding service, clean stale binding only",
vo.getUuid(), vo.getVmNicUuid(), struct.getGuestL3Network().getUuid()));
detachPortForwardingRuleInDb(vo);
PortForwardingRuleVO prvo = dbf.reload(vo);
evt.setInventory(PortForwardingRuleInventory.valueOf(prvo));
bus.publish(evt);
return;
}

detachPortForwardingRule(struct, providerType.toString(), new Completion(msg) {
@Override
Expand All @@ -429,10 +438,44 @@ private VmInstanceState getVmStateFromVmNicUuid(String vmNicUuid) {
VmInstanceState.class).param("nicUuid", vmNicUuid).find();
}

private NetworkServiceProviderType getPortForwardingProviderType(String l3NetworkUuid) {
return nwServiceMgr.getTypeOfNetworkServiceProviderForService(l3NetworkUuid, NetworkServiceType.PortForwarding);
}

private NetworkServiceProviderType getPortForwardingProviderTypeIfEnabled(String l3NetworkUuid) {
try {
return getPortForwardingProviderType(l3NetworkUuid);
} catch (OperationFailureException e) {
if (!isPortForwardingServiceMissing(e.getErrorCode())) {
throw e;
}
return null;
}
}

private boolean isPortForwardingServiceMissing(ErrorCode errorCode) {
return errorCode != null && (ORG_ZSTACK_NETWORK_SERVICE_10005.equals(errorCode.getGlobalErrorCode())
|| ORG_ZSTACK_NETWORK_SERVICE_10005.equals(errorCode.getCode()));
}

private void detachPortForwardingRuleInDb(PortForwardingRuleVO vo) {
SQL.New(PortForwardingRuleVO.class).eq(PortForwardingRuleVO_.uuid, vo.getUuid())
.set(PortForwardingRuleVO_.vmNicUuid, null)
.set(PortForwardingRuleVO_.guestIp, null).update();
}

private void handle(final APIAttachPortForwardingRuleMsg msg) {
final APIAttachPortForwardingRuleEvent evt = new APIAttachPortForwardingRuleEvent(msg.getId());
PortForwardingRuleVO vo = dbf.findByUuid(msg.getRuleUuid(), PortForwardingRuleVO.class);
VmNicVO nicvo = dbf.findByUuid(msg.getVmNicUuid(), VmNicVO.class);
final NetworkServiceProviderType providerType;
try {
providerType = getPortForwardingProviderType(nicvo.getL3NetworkUuid());
} catch (OperationFailureException e) {
evt.setError(e.getErrorCode());
bus.publish(evt);
return;
}
vo.setVmNicUuid(nicvo.getUuid());
vo.setGuestIp(nicvo.getIp());
L3NetworkVO nicL3Vo = dbf.findByUuid(nicvo.getL3NetworkUuid(), L3NetworkVO.class);
Expand All @@ -445,9 +488,6 @@ private void handle(final APIAttachPortForwardingRuleMsg msg) {
ModifyVipAttributesStruct struct = new ModifyVipAttributesStruct();
struct.setUseFor(PortForwardingConstant.PORTFORWARDING_NETWORK_SERVICE_TYPE);
struct.setServiceUuid(vo.getUuid());
final NetworkServiceProviderType providerType =
nwServiceMgr.getTypeOfNetworkServiceProviderForService(
nicvo.getL3NetworkUuid(), NetworkServiceType.PortForwarding);
struct.setServiceProvider(providerType.toString());
struct.setPeerL3NetworkUuid(nicvo.getL3NetworkUuid());
vip.setStruct(struct);
Expand All @@ -460,6 +500,7 @@ public void success() {

@Override
public void fail(ErrorCode errorCode) {
detachPortForwardingRuleInDb(vo);
evt.setError(errorCode);
bus.publish(evt);
}
Expand All @@ -468,7 +509,6 @@ public void fail(ErrorCode errorCode) {
}

final PortForwardingStruct struct = makePortForwardingStruct(inv);
final NetworkServiceProviderType providerType = nwServiceMgr.getTypeOfNetworkServiceProviderForService(struct.getGuestL3Network().getUuid(), NetworkServiceType.PortForwarding);
attachPortForwardingRule(struct, providerType.toString(), new Completion(msg) {
@Override
public void success() {
Expand Down Expand Up @@ -519,8 +559,29 @@ public void fail(ErrorCode errorCode) {
}

final PortForwardingStruct struct = makePortForwardingStruct(inv);
final NetworkServiceProviderType providerType = nwServiceMgr.getTypeOfNetworkServiceProviderForService(struct.getGuestL3Network().getUuid(),
NetworkServiceType.PortForwarding);
final NetworkServiceProviderType providerType = getPortForwardingProviderTypeIfEnabled(struct.getGuestL3Network().getUuid());
if (providerType == null) {
logger.warn(String.format("port forwarding rule[uuid:%s] is attached to vm nic[uuid:%s] on L3[uuid:%s] without PortForwarding service, release VIP service and delete stale binding",
vo.getUuid(), vo.getVmNicUuid(), struct.getGuestL3Network().getUuid()));
ModifyVipAttributesStruct vipStruct = new ModifyVipAttributesStruct();
vipStruct.setUseFor(PortForwardingConstant.PORTFORWARDING_NETWORK_SERVICE_TYPE);
vipStruct.setServiceUuid(vo.getUuid());
Vip v = new Vip(inv.getVipUuid());
v.setStruct(vipStruct);
v.release(new Completion(complete) {
@Override
public void success() {
dbf.remove(vo);
complete.success();
}

@Override
public void fail(ErrorCode errorCode) {
complete.fail(errorCode);
}
});
return;
}

for (RevokePortForwardingRuleExtensionPoint extp : revokeRuleExts) {
try {
Expand Down Expand Up @@ -576,9 +637,6 @@ public void run(FlowTrigger trigger, Map data) {
vipStruct.setUseFor(PortForwardingConstant.PORTFORWARDING_NETWORK_SERVICE_TYPE);
vipStruct.setServiceUuid(vo.getUuid());
if (struct.getGuestL3Network() != null) {
final NetworkServiceProviderType providerType =
nwServiceMgr.getTypeOfNetworkServiceProviderForService(
struct.getGuestL3Network().getUuid(), NetworkServiceType.PortForwarding);
vipStruct.setServiceProvider(providerType.toString());
vipStruct.setPeerL3NetworkUuid(struct.getGuestL3Network().getUuid());
}
Expand Down Expand Up @@ -746,6 +804,20 @@ private void doCreatePortForwardingRule(APICreatePortForwardingRuleMsg msg, Sync
}

VipVO vip = dbf.findByUuid(msg.getVipUuid(), VipVO.class);
VmNicVO vmNic = msg.getVmNicUuid() == null ? null : dbf.findByUuid(msg.getVmNicUuid(), VmNicVO.class);
final NetworkServiceProviderType providerType;
if (vmNic == null) {
providerType = null;
} else {
try {
providerType = getPortForwardingProviderType(vmNic.getL3NetworkUuid());
} catch (OperationFailureException e) {
evt.setError(e.getErrorCode());
bus.publish(evt);
syncChain.next();
return;
}
}
final PortForwardingRuleVO vo = new PortForwardingRuleVO();
if (msg.getResourceUuid() != null) {
vo.setUuid(msg.getResourceUuid());
Expand Down Expand Up @@ -802,7 +874,6 @@ public void fail(ErrorCode errorCode) {
return;
}

VmNicVO vmNic = dbf.findByUuid(msg.getVmNicUuid(), VmNicVO.class);
SimpleQuery<VmInstanceVO> q = dbf.createQuery(VmInstanceVO.class);
q.select(VmInstanceVO_.state);
q.add(VmInstanceVO_.uuid, Op.EQ, vmNic.getVmInstanceUuid());
Expand Down Expand Up @@ -845,9 +916,6 @@ public void setup() {
flow(new NoRollbackFlow() {
@Override
public void run(FlowTrigger trigger, Map data) {
final NetworkServiceProviderType providerType = nwServiceMgr.getTypeOfNetworkServiceProviderForService(vmNic.getL3NetworkUuid(),
NetworkServiceType.PortForwarding);

for (AttachPortForwardingRuleExtensionPoint extp : attachRuleExts) {
try {
extp.preAttachPortForwardingRule(ruleInv, providerType);
Expand Down Expand Up @@ -993,8 +1061,15 @@ public void run(SyncTaskChain chain) {
}

PortForwardingStruct struct = makePortForwardingStruct(PortForwardingRuleInventory.valueOf(pf));
final NetworkServiceProviderType providerType = nwServiceMgr.getTypeOfNetworkServiceProviderForService(struct.getGuestL3Network().getUuid(),
NetworkServiceType.PortForwarding);
final NetworkServiceProviderType providerType = getPortForwardingProviderTypeIfEnabled(struct.getGuestL3Network().getUuid());
if (providerType == null) {
logger.warn(String.format("port forwarding rule[uuid:%s] is attached to vm nic[uuid:%s] on L3[uuid:%s] without PortForwarding service, release stale VIP service directly",
pf.getUuid(), pf.getVmNicUuid(), struct.getGuestL3Network().getUuid()));
dbf.remove(pf);
completion.success();
chain.next();
return;
}
PortForwardingBackend bkd = getPortForwardingBackend(providerType);
bkd.revokePortForwardingRule(struct, new Completion(completion) {
@Override
Expand Down
Loading