<fix>[gpu]: add gpu normalized model schema#4410
Open
ZStack-Robot wants to merge 1 commit into
Open
Conversation
Backport the normalizedModelName schema required by premium GPU spec deduplication to 5.4.10. This is the zstack companion change for the premium ZSTAC-86476 backport. Constraint: ZSTAC-86476 is the 5.4.10 clone of ZSTAC-75319. Confidence: high Scope-risk: narrow Tested: ./runMavenProfile premium in pr-build-bin Docker with zstack and premium mounted Not-tested: local stability case execution Resolves: ZSTAC-86476 Change-Id: Ic77e24e974a99842c40f29e4bd72851e3833795b
|
Warning
|
| Layer / File(s) | Summary |
|---|---|
新增归一化型号名称列及索引 conf/db/upgrade/V5.4.10__schema.sql |
为GpuDeviceSpecVO表添加normalizedModelName列并创建对应索引,支持按归一化型号名称查询。 |
Estimated code review effort: 1 (Trivial) | ~2 minutes
Poem
一列新增,索引轻描,
型号归一,查找更巧。
兔子敲键,小小改造,
数据库中,跳跃奔跑 🐇✨
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
| Check name | Status | Explanation |
|---|---|---|
| Title check | ✅ Passed | 标题准确概括了本次为 GPU 归一化型号补充 schema 的主要变更。 |
| Description check | ✅ Passed | 描述与变更一致,明确说明了新增列和索引以及回溯目的。 |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Commit unit tests in branch
sync/ye.zou/fix/ZSTAC-86476-5.4.10@@2
Comment @coderabbitai help to get the list of available commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GpuDeviceSpecVO.normalizedModelNamecolumn and index required by the premium dedup logic.Root Cause
Verification
./runMavenProfile premiuminregistry.docker.zstack.io:80/pr-build-bin:2.41test-4with zstack and premium mounted.Resolves: ZSTAC-86476
sync from gitlab !10370