Skip to content

<fix>[gpu]: add gpu normalized model schema#4410

Open
ZStack-Robot wants to merge 1 commit into
5.4.10from
sync/ye.zou/fix/ZSTAC-86476-5.4.10@@2
Open

<fix>[gpu]: add gpu normalized model schema#4410
ZStack-Robot wants to merge 1 commit into
5.4.10from
sync/ye.zou/fix/ZSTAC-86476-5.4.10@@2

Conversation

@ZStack-Robot

Copy link
Copy Markdown
Collaborator

Summary

  • Backport the ZSTAC-75319 GPU spec normalization schema to 5.4.10 for ZSTAC-86476.
  • Add GpuDeviceSpecVO.normalizedModelName column and index required by the premium dedup logic.

Root Cause

  • GPU spec identity in the premium code path needs a normalized model key so same GPU models from different board vendors can be unified.

Verification

  • ./runMavenProfile premium in registry.docker.zstack.io:80/pr-build-bin:2.41test-4 with zstack and premium mounted.

Resolves: ZSTAC-86476

sync from gitlab !10370

Backport the normalizedModelName schema required by premium GPU spec deduplication to 5.4.10. This is the zstack companion change for the premium ZSTAC-86476 backport.

Constraint: ZSTAC-86476 is the 5.4.10 clone of ZSTAC-75319.
Confidence: high
Scope-risk: narrow
Tested: ./runMavenProfile premium in pr-build-bin Docker with zstack and premium mounted
Not-tested: local stability case execution

Resolves: ZSTAC-86476

Change-Id: Ic77e24e974a99842c40f29e4bd72851e3833795b
@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

.coderabbit.yaml has a parsing error

The CodeRabbit configuration file in this repository has a parsing error and default settings were used instead. Please fix the error(s) in the configuration file. You can initialize chat with CodeRabbit to get help with the configuration file.

💥 Parsing errors (1)
Could not fetch remote config from http://open.zstack.ai:20001/code-reviews/zstack-cloud.yaml: TimeoutError: The operation was aborted due to timeout
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: de1b5070-1d95-459c-b843-1f75bca38ffb

📥 Commits

Reviewing files that changed from the base of the PR and between 08177ca and f25df0a.

📒 Files selected for processing (1)
  • conf/db/upgrade/V5.4.10__schema.sql

Walkthrough

该PR为数据库升级脚本,在GpuDeviceSpecVO表中新增normalizedModelName列(VARCHAR(255),默认NULL),并创建对应索引idx_gpu_spec_normalized_model,用于支持按归一化型号名称查询。

Changes

数据库升级脚本

Layer / File(s) Summary
新增归一化型号名称列及索引
conf/db/upgrade/V5.4.10__schema.sql
为GpuDeviceSpecVO表添加normalizedModelName列并创建对应索引,支持按归一化型号名称查询。

Estimated code review effort: 1 (Trivial) | ~2 minutes

Poem

一列新增,索引轻描,
型号归一,查找更巧。
兔子敲键,小小改造,
数据库中,跳跃奔跑 🐇✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed 标题准确概括了本次为 GPU 归一化型号补充 schema 的主要变更。
Description check ✅ Passed 描述与变更一致,明确说明了新增列和索引以及回溯目的。
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sync/ye.zou/fix/ZSTAC-86476-5.4.10@@2

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants