Skip to content

<fix>[lb]: support tcp ipvs listener params#4403

Open
zstack-robot-2 wants to merge 1 commit into
feature-5.5.28-lb-ipvsfrom
sync/dejing.liu/codex/sug-2795-haproxy-udp-groovy-tests
Open

<fix>[lb]: support tcp ipvs listener params#4403
zstack-robot-2 wants to merge 1 commit into
feature-5.5.28-lb-ipvsfrom
sync/dejing.liu/codex/sug-2795-haproxy-udp-groovy-tests

Conversation

@zstack-robot-2

Copy link
Copy Markdown
Collaborator

Expose TCP IPVS balancerAlgorithm and maxConnection.

Return them from create, change, and query inventory paths.

Allow TCP IPVS NAT and DR forward modes in Cloud validation.

Update the create API docs for the supported forward modes.

Cover REST returns and /lb/refresh payloads after create and change.

Test: TcpIpvsLoadBalancerListenerApiCase

Test: mvn test -Dtest=ZStackTest

Test: -DsubCaseCollectionStrategy=Designated

Test: -DcaseFilePath=/tmp/sug2795-tcp-ipvs-case.txt

Test: -Djacoco.skip=true

Resolves: ZSTAC-86152

Change-Id: If8e04660f1c490b9556c35e192c2e39e2dbb66ca

sync from gitlab !10363

@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 26 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: http://open.zstack.ai:20001/code-reviews/zstack-cloud.yaml (via .coderabbit.yaml)

Review profile: CHILL

Plan: Pro

Run ID: 177b276d-b7cb-4599-937c-03ddf2d537df

📥 Commits

Reviewing files that changed from the base of the PR and between 7e6d987 and b84c1d4.

⛔ Files ignored due to path filters (2)
  • sdk/src/main/java/org/zstack/sdk/ChangeLoadBalancerListenerAction.java is excluded by !sdk/**
  • sdk/src/main/java/org/zstack/sdk/LoadBalancerListenerInventory.java is excluded by !sdk/**
📒 Files selected for processing (8)
  • plugin/loadBalancer/src/main/java/org/zstack/network/service/lb/APIChangeLoadBalancerListenerMsg.java
  • plugin/loadBalancer/src/main/java/org/zstack/network/service/lb/APIChangeLoadBalancerListenerMsgDoc_zh_cn.groovy
  • plugin/loadBalancer/src/main/java/org/zstack/network/service/lb/APICreateLoadBalancerListenerMsgDoc_zh_cn.groovy
  • plugin/loadBalancer/src/main/java/org/zstack/network/service/lb/LoadBalancerApiInterceptor.java
  • plugin/loadBalancer/src/main/java/org/zstack/network/service/lb/LoadBalancerBase.java
  • plugin/loadBalancer/src/main/java/org/zstack/network/service/lb/LoadBalancerListenerInventory.java
  • test/src/test/groovy/org/zstack/test/integration/networkservice/provider/virtualrouter/loadbalancer/TcpIpvsLoadBalancerListenerApiCase.groovy
  • utils/src/main/java/org/zstack/utils/clouderrorcode/CloudOperationsErrorCode.java
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sync/dejing.liu/codex/sug-2795-haproxy-udp-groovy-tests

Comment @coderabbitai help to get the list of available commands.

@MatheMatrix MatheMatrix force-pushed the sync/dejing.liu/codex/sug-2795-haproxy-udp-groovy-tests branch 3 times, most recently from 28f2de4 to 5463261 Compare July 2, 2026 15:36
Add dataPlane and forwardMode to TCP listener create and inventory paths
so Cloud can select the IPVS data plane for L4 listeners.

Reject forwardMode updates after listener creation and reject
healthCheckTimeout for TCP IPVS listeners because the IPVS health
daemon does not consume that HAProxy-style timeout.

Regenerate the load balancer listener API doc templates so the
API template check stays clean after docpremium generation.

Test: mvn -pl plugin/loadBalancer -am -DskipTests install
Test: ./runMavenProfile docpremium
Resolves: ZSTAC-86152
Change-Id: I34d94c59651369e7de9d8ae9b33f7e6025300948
@MatheMatrix MatheMatrix force-pushed the sync/dejing.liu/codex/sug-2795-haproxy-udp-groovy-tests branch from 5463261 to b84c1d4 Compare July 3, 2026 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant