<feature>[sdk]: Add getVmHaNetworkGroupRiskOnHost method#3462
<feature>[sdk]: Add getVmHaNetworkGroupRiskOnHost method#3462ZStack-Robot wants to merge 1 commit intofeature-5.5.6-dpu-net-ha2from
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: http://open.zstack.ai:20001/code-reviews/zstack-cloud.yaml (via .coderabbit.yaml) Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (4)
📒 Files selected for processing (2)
Walkthrough新增了一个同步调用方法 Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 分钟 Poem
Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error)
✅ Passed checks (2 passed)
✨ Finishing Touches
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ast-grep (0.41.0)utils/src/main/java/org/zstack/utils/clouderrorcode/CloudOperationsErrorCode.javaComment |
|
Comment from yaohua.wu: Review: MR !9321 (zstack) — ZSTAC-83065本 MR 为 premium MR !13135 的 SDK/测试配套变更,包含:
所有文件均为标准生成/注册代码,与 premium 侧 API 定义一致,无问题。 详细 review 见 premium MR:http://dev.zstack.io:9080/zstackio/premium/-/merge_requests/13135#note_679009 Verdict: APPROVED🤖 Robot Reviewer |
| import java.util.Map; | ||
| import org.zstack.sdk.*; | ||
|
|
||
| public class GetVmHaNetworkGroupRiskOnHostAction extends AbstractAction { |
There was a problem hiding this comment.
Comment from yaohua.wu:
直接叫Status?Risk本身就有风险的意思,但是本质上这个API的返回不是只返回风险,available本身不属于风险范畴
Resolves: ZSTAC-83065 Change-Id: I6d6f71667972646b71746c6c656e676c70657467
160f69a to
ebc3778
Compare
Resolves: ZSTAC-83065
Change-Id: I6d6f71667972646b71746c6c656e676c70657467
sync from gitlab !9321