Include path if the base url is generated from the request URL.#1602
Draft
JPBergsma wants to merge 5 commits intoMaterials-Consortia:mainfrom
Draft
Include path if the base url is generated from the request URL.#1602JPBergsma wants to merge 5 commits intoMaterials-Consortia:mainfrom
JPBergsma wants to merge 5 commits intoMaterials-Consortia:mainfrom
Conversation
Contributor
Author
|
|
…ath from parsed URL.
Codecov Report
@@ Coverage Diff @@
## master #1602 +/- ##
=======================================
Coverage 91.04% 91.05%
=======================================
Files 74 74
Lines 4578 4583 +5
=======================================
+ Hits 4168 4173 +5
Misses 410 410
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Contributor
Author
|
I just noticed that this PR has a lot in common with PR #663 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in get_base_url.
If the base URL is not specified in the config file, the function get_base_url extracts the base URL from the request URL.
The current function, however, only returns the scheme (e.g. https) and netloc(e.g. www.example.com) part of the base URL.
A base URL may however also contain a root path (e.g. /optimade).
This patch adds the root path to the base URL.