dbt-materialize: pass the schema name when tagging deployment schemas in deploy_init - #38066
Draft
bobbyiliev wants to merge 1 commit into
Draft
dbt-materialize: pass the schema name when tagging deployment schemas in deploy_init#38066bobbyiliev wants to merge 1 commit into
bobbyiliev wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
CI_TAGis set,deploy_initcalled the schema tagging macro without the schema name, so it ranCOMMENT ON SCHEMA ""and the whole operation failed. SinceCI_TAGis the variable our blue/green CI docs tell people to set, this broke deploy_init in the setup it was built for, so this passes the deployment schema through and quotes it on creation the same way it is quoted on drop.Test plan: added a case to
test_deploy.pythat runsdeploy_initwithCI_TAGset and checks the tag lands on both deployment schemas.