dbt-materialize: fix the missing deployment timestamp in deploy_promote schema tags - #38064
Draft
bobbyiliev wants to merge 1 commit into
Draft
dbt-materialize: fix the missing deployment timestamp in deploy_promote schema tags#38064bobbyiliev wants to merge 1 commit into
bobbyiliev wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The comment that
deploy_promoteputs on each promoted schema was reading the second row of the first column of a one row result, which Jinja turns into an empty value, so every tag ended with "on " and no timestamp. It now reads the second column of the first row.Test plan: the existing deploy test asserted only that the word "on" was present, which matched the template text itself, so it now matches the user and timestamp with a regex.