dbt-materialize: make strict_mode schema isolation fire for views, materialized views and tables - #38063
Draft
bobbyiliev wants to merge 1 commit into
Draft
Conversation
…terialized views and tables
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The strict_mode check that keeps views, materialized views and tables out of schemas reserved for sources, source tables and sinks never actually ran, because the flags it set inside a Jinja loop were dropped when the loop ended. This moves the flags into a namespace so the check works, and adds tests that build only the blocked model so each direction of the rule is covered on its own.
Test plan: added three cases to
test_strict_mode.pythat select just the view and assert the error message.