sql: Reject non-MANUAL SCHEDULE on a cluster with REPLICATION FACTOR > 1#37068
Merged
ggevay merged 1 commit intoJun 16, 2026
Merged
Conversation
A cluster with a refresh schedule is turned on/off by the cluster scheduling policy, so its replication factor is always 0 or 1. But `ALTER CLUSTER ... SET (SCHEDULE = ON REFRESH)` on a cluster that already had a higher replication factor left it in an invalid state, which made `SHOW CREATE CLUSTER` panic the coordinator. Reject such an ALTER at plan time, pointing the user to lower the replication factor first. As defense in depth, downgrade the assertion in `unplan_create_cluster` to a soft assert so a cluster that somehow ends up in this state can no longer crash the coordinator. Adds a regression test to test/sqllogictest/materialized_views.slt. SQL-215 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
aljoscha
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes SQL-215
A cluster with a refresh schedule is turned on/off by the cluster scheduling policy, so its replication factor is always 0 or 1. But
ALTER CLUSTER ... SET (SCHEDULE = ON REFRESH)on a cluster that already had a higher replication factor left it in an invalid state, which madeSHOW CREATE CLUSTERpanic the coordinator.Reject such an ALTER at plan time, pointing the user to lower the replication factor first. As defense in depth, downgrade the assertion in
unplan_create_clusterto a soft assert so a cluster that somehow ends up in this state can no longer crash the coordinator.