sql: Reject unsupported COPY FROM URL/S3 formats in planning#37065
Merged
ggevay merged 1 commit intoJun 16, 2026
Conversation
COPY FROM a URL or S3 source only supports CSV and Parquet, but the format was never validated against the source during planning. The format defaulted to TEXT when omitted, so both `COPY FROM <url>` with no FORMAT and an explicit `FORMAT text`/`binary` produced a plan that the coordinator could not execute, tripping a soft-panic in sequence_copy_from. Validate the format against the source in plan_copy_from: STDIN keeps its TEXT default, while URL/S3 sources now require an explicit FORMAT and reject TEXT/BINARY with a clear planning error. COPY FROM STDIN and both COPY TO directions are unaffected. Adds testdrive coverage to copy-from-s3-minio.td for the formatless URL, explicit TEXT URL, and explicit TEXT S3 cases. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
aljoscha
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
COPY FROM a URL or S3 source only supports CSV and Parquet, but the format was never validated against the source during planning. The format defaulted to TEXT when omitted, so both
COPY FROM <url>with no FORMAT and an explicitFORMAT text/binaryproduced a plan that the coordinator could not execute, tripping a soft-panic in sequence_copy_from.Validate the format against the source in plan_copy_from: STDIN keeps its TEXT default, while URL/S3 sources now require an explicit FORMAT and reject TEXT/BINARY with a clear planning error. COPY FROM STDIN and both COPY TO directions are unaffected.
Adds testdrive coverage to copy-from-s3-minio.td for the formatless URL, explicit TEXT URL, and explicit TEXT S3 cases.