Edu 51 privatelink nlb cleanup#37056
Open
kay-kim wants to merge 2 commits into
Open
Conversation
kay-kim
commented
Jun 16, 2026
| You **do not need** to specify `AVAILABILITY ZONES` manually — these will | ||
| be optimally auto-assigned when none are provided. | ||
|
|
||
| - name: nlb-security-group-remarks |
Contributor
Author
There was a problem hiding this comment.
👉 This content is the single-sourced content to review.
kay-kim
commented
Jun 16, 2026
| --- | ||
| headless: true | ||
| --- | ||
| 1. Get the IP address of your __INSTANCE__ instance. You'll need this address to register |
Contributor
Author
There was a problem hiding this comment.
can ignore. just single-sourcing with placeholder variables. Most of the changes in this PR can be ignored.
The actual content to review is in yaml https://github.com/MaterializeInc/materialize/pull/37056/changes#r3417506456
kay-kim
commented
Jun 16, 2026
|
|
||
| e. Click next, and register the respective __INSTANCE__ instance to the target group using its IP address. | ||
|
|
||
| 1. #### Verify security groups and health checks |
Contributor
Author
There was a problem hiding this comment.
Moved this down after creating NLB since we refer to NLBs before we create the NLBs. (this is now consistent with order in the privatelink kafka steps).
This was referenced Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first patch just single-sources existing content where possible. <<-- can ignore/skip
The second patch 6b294d0 covers both (this is the one to review):