Skip to content

Support CornerRadius in Clock control#4054

Open
corvinsz wants to merge 4 commits into
MaterialDesignInXAML:masterfrom
corvinsz:fixClockCornerRadius
Open

Support CornerRadius in Clock control#4054
corvinsz wants to merge 4 commits into
MaterialDesignInXAML:masterfrom
corvinsz:fixClockCornerRadius

Conversation

@corvinsz
Copy link
Copy Markdown
Member

The Clock exposes a CornerRadius property but does not actually use it in it's template.

The converter FixedBottomCornerRadiusConverter is there to apply the CornerRadius to only the top left & top right corners of the "header":
image

Copy link
Copy Markdown
Contributor

@nicolaihenriksen nicolaihenriksen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Perhaps consider an explicit default value for the CornerRadius in the (base) style? If I am not mistaken, the old code would use "2", where the new code will use "0" unless you explicitly set it to something else?

@corvinsz
Copy link
Copy Markdown
Member Author

@nicolaihenriksen you are indeed correct, thanks for the heads up.
For some reasons a few styles already had a CornerRadius of 8 applied to them. I just left them as is.

Comment thread src/MaterialDesignThemes.Wpf/Themes/MaterialDesignTheme.Clock.xaml Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants