Skip to content

Use hidePreviewButtons for side-by-side only #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cyanzhong merged 4 commits into from
Mar 20, 2026
Merged

Use hidePreviewButtons for side-by-side only #83

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2b54ef8
Initial plan
Copilot Mar 20, 2026
f6b5128
Improve hidePreviewButtons: scope to side-by-side mode and support li…
Copilot Mar 20, 2026
aa46380
Update README: use user-facing "table preview buttons" instead of DOM…
Copilot Mar 20, 2026
30c08a9
Remove hidePreviewButtons lite build support for consistency
Copilot Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ In [settings.json](https://github.com/MarkEdit-app/MarkEdit/wiki/Customization#a

- `updateBehavior`: `"quiet"` shows a button, `"notify"` shows an alert, `"never"` disables update checks.
- `syncScroll`: Whether to enable scroll synchronization.
- `hidePreviewButtons`: Whether to hide the built-in preview buttons (not applicable for lite build).
- `hidePreviewButtons`: Whether to hide the built-in preview buttons in side-by-side mode (for lite build, hides preview buttons under table wrappers only).
Copy link
Copy Markdown
Contributor

@cyanzhong cyanzhong Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot I don't think we should use the word under, for users, this is just a preview button for table.

Copy link
Copy Markdown
Contributor Author

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in aa46380 — changed to "hides table preview buttons only".

- `syntaxAutoDetect`: Whether to enable automatic language detection for syntax highlighting in code blocks (not applicable for lite build).
- `imageHoverPreview`: Whether to enable image preview on hover.
- `themeName`: Set the preview color theme, available themes can be found in the [`styles/themes`](styles/themes) folder.
Expand Down
11 changes: 9 additions & 2 deletions src/view.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,16 @@ export function setUp() {
import('../styles/katex.css?raw').then(mod => appendStyle(mod.default));
appendStyle(hljsCss());

// Hide the built-in preview button since we have a better preview with all features
// Hide the built-in preview buttons in side-by-side mode
if (hidePreviewButtons) {
appendStyle(`.cm-md-previewWrapper {
appendStyle(`.markdown-container .cm-md-previewWrapper {
display: none !important;
}`);
}
} else {
// For lite build, hide preview buttons under table wrapper in side-by-side mode
if (hidePreviewButtons) {
appendStyle(`.markdown-container .cm-md-tableWrapper .cm-md-previewWrapper {
display: none !important;
}`);
}
Expand Down