Skip to content

MDEV-10526: Add binary string support to bitwise operators #5190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kjarir wants to merge 12 commits into
base: main
Choose a base branch
from
+2,436 −98
Draft

MDEV-10526: Add binary string support to bitwise operators #5190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
15d6cd6
MDEV-10526: Add binary string support to bitwise operators
kjarir Jun 6, 2026
f1309a2
MDEV-10526: Address code review feedback on bitwise binary handlers
kjarir Jun 10, 2026
01d54c0
MDEV-10526: Implement binary mode for bitwise aggregate functions
kjarir Jun 11, 2026
decba38
MDEV-10526: Implement reset_field/update_field for binary mode aggreg…
kjarir Jun 11, 2026
6b9dd9e
MDEV-10526: Add inet4 and geometry to type restriction tests
kjarir Jun 11, 2026
08a5eb2
MDEV-10526: Fix regressions in main.gis and main.func_json
kjarir Jun 14, 2026
389d297
MDEV-10526: Add boundary, large-literal, and coercibility tests
kjarir Jun 14, 2026
567edd6
MDEV-10526: Add mediumblob/longblob escalation tests to Section 11
kjarir Jun 14, 2026
eeb3b5d
MDEV-10526: Implement Alexander's type-handler-based binary mode dete…
kjarir Jun 19, 2026
cbf5aac
MDEV-10526: Use warning instead of error for mismatched bitwise opera…
kjarir Jun 19, 2026
821455e
MDEV-10526: Add window function support for binary mode aggregates
kjarir Jun 19, 2026
66410ee
MDEV-10526: Add Spider direct_add() support for bitwise aggregates
kjarir Jun 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
477 changes: 477 additions & 0 deletions mysql-test/main/func_bitops_binary.result
View file
Open in desktop

Large diffs are not rendered by default.

396 changes: 396 additions & 0 deletions mysql-test/main/func_bitops_binary.test
View file
Open in desktop

Large diffs are not rendered by default.

70 changes: 0 additions & 70 deletions sql/item_cmpfunc.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5062,76 +5062,6 @@ bool Item_func_in::ora_join_processor(void *arg)
return FALSE;
}


class Func_handler_bit_or_int_to_ulonglong:
public Item_handled_func::Handler_ulonglong
{
public:
Longlong_null to_longlong_null(Item_handled_func *item) const override
{
DBUG_ASSERT(item->fixed());
Longlong_null a= item->arguments()[0]->to_longlong_null();
return a.is_null() ? a : a | item->arguments()[1]->to_longlong_null();
}
};


class Func_handler_bit_or_dec_to_ulonglong:
public Item_handled_func::Handler_ulonglong
{
public:
Longlong_null to_longlong_null(Item_handled_func *item) const override
{
DBUG_ASSERT(item->fixed());
VDec a(item->arguments()[0]);
return a.is_null() ? Longlong_null() :
a.to_xlonglong_null() | VDec(item->arguments()[1]).to_xlonglong_null();
}
};


bool Item_func_bit_or::fix_length_and_dec(THD *thd)
{
static Func_handler_bit_or_int_to_ulonglong ha_int_to_ull;
static Func_handler_bit_or_dec_to_ulonglong ha_dec_to_ull;
return fix_length_and_dec_op2_std(&ha_int_to_ull, &ha_dec_to_ull);
}


class Func_handler_bit_and_int_to_ulonglong:
public Item_handled_func::Handler_ulonglong
{
public:
Longlong_null to_longlong_null(Item_handled_func *item) const override
{
DBUG_ASSERT(item->fixed());
Longlong_null a= item->arguments()[0]->to_longlong_null();
return a.is_null() ? a : a & item->arguments()[1]->to_longlong_null();
}
};


class Func_handler_bit_and_dec_to_ulonglong:
public Item_handled_func::Handler_ulonglong
{
public:
Longlong_null to_longlong_null(Item_handled_func *item) const override
{
DBUG_ASSERT(item->fixed());
VDec a(item->arguments()[0]);
return a.is_null() ? Longlong_null() :
a.to_xlonglong_null() & VDec(item->arguments()[1]).to_xlonglong_null();
}
};


bool Item_func_bit_and::fix_length_and_dec(THD *thd)
{
static Func_handler_bit_and_int_to_ulonglong ha_int_to_ull;
static Func_handler_bit_and_dec_to_ulonglong ha_dec_to_ull;
return fix_length_and_dec_op2_std(&ha_int_to_ull, &ha_dec_to_ull);
}

Item_cond::Item_cond(THD *thd, Item_cond *item)
:Item_bool_func(thd, item),
and_tables_cache(item->and_tables_cache)
Expand Down
Loading