MDEV-39523 UBSAN on ST_COLLECT (has_cached_value)#5044
Open
grooverdan wants to merge 1 commit intoMariaDB:12.3from
Open
MDEV-39523 UBSAN on ST_COLLECT (has_cached_value)#5044grooverdan wants to merge 1 commit intoMariaDB:12.3from
grooverdan wants to merge 1 commit intoMariaDB:12.3from
Conversation
grooverdan
added
the
MariaDB Foundation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request addresses a UBSAN error (MDEV-38755) by initializing the has_cached_result member variable in the Item_func_collect constructors. It also adds regression tests for spatial utility functions when processing empty tables. I have no feedback to provide.
grooverdan
force-pushed
the
MDEV-39523
branch
2 times, most recently
from
40e3400 to
1c95e68
Compare
UBSAN errored with UBSAN: load of value 165, which is not a valid value for type 'bool' on SELECT ST_COLLECT. This was Item_func_collect::val_str reading the has_cached_value. The member variable has_cached_value was set to true later in this function when it had a cached value. There was no initialization of has_cached_value to false in the constructor. We copy the cached value if the Item_func_collect is copied.
grooverdan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UBSAN errored with UBSAN: load of value 165, which is not a valid value for type 'bool' on SELECT ST_COLLECT.
This was Item_func_collect::val_str reading the has_cached_value. The member variable has_cached_value was set to true later in this function when it had a cached value. There was no initialization of has_cached_value to false in the constructor.