MDEV-35595 UBSAN: runtime error: load of value 3 for wkbByteOrder#5032
Open
grooverdan wants to merge 1 commit intoMariaDB:10.11from
Open
MDEV-35595 UBSAN: runtime error: load of value 3 for wkbByteOrder#5032grooverdan wants to merge 1 commit intoMariaDB:10.11from
grooverdan wants to merge 1 commit intoMariaDB:10.11from
Conversation
When creating Geometry objects from raw bytes, validate the byte order is not > wkb_ndr, a constant for little endian being the upper bound of the wkbByteOrder. The 3 validation locations are the callers to the other init_from_wkb functions for other geometry types, which prevent an invalid value from reaching wkb_get_uint.
grooverdan
added
the
MariaDB Foundation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When creating Geometry objects from raw bytes, validate the byte order is not > wkb_ndr, a constant for little endian being the upper bound of the wkbByteOrder.
The 3 validation locations are the callers to the other init_from_wkb functions for other geometry types, which prevent an invalid value from reaching wkb_get_uint.