Conversation
MariaDB 5.5 has been EOL for 6 years, and MySQL 5.5 for almost 7½ years. Code improvements are therefore no longer obliged to retain a slightly divergent path that supports upgrades from those versions.
This commit refactors the static lists of bulky member pointer substitutes to instance-level lists of on-demand references. The choice of these static lists was an aggressive optimization. Once operations reduce dependence on saving and loading, e.g., for crash safety in non-GTID mode, that improvement will no longer be significant.
…ructures We currently (should) use in-house data structures; those in the C++ Standard Library are not yet formally approved. Until that day comes (if ever), this commit swaps the set of data structures. As this commit contains no other significant refactoring, this change from one library to the other is also a sample for static and performance comparisons.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move
Info_files’VALUE_LISTs to for-eachThis commit refactors the static lists of bulky member pointer substitutes to instance-level lists of on-demand references.
The choice of these static lists was an aggressive optimization.
Once operations reduce dependence on saving and loading, e.g., for crash safety in non-GTID mode, that improvement will no longer be significant.
MDEV-38972 Refactor MDEV-37530 and MDEV-28302 to Use Internal Data Structures
We currently (should) use in-house data structures; those in the C++ Standard Library are not yet formally approved.
Until that day comes (if ever), this commit swaps the set of data structures.
As this commit contains no other significant refactoring, this change from one library to the other is also a sample for static and performance comparisons.