MDEV-30612: Fix usage of lex->definer in wsrep_create_trigger_query#4798
Open
mariadb-DenisProtivensky wants to merge 1 commit intoMariaDB:10.11from
Open
MDEV-30612: Fix usage of lex->definer in wsrep_create_trigger_query#4798mariadb-DenisProtivensky wants to merge 1 commit intoMariaDB:10.11from
mariadb-DenisProtivensky wants to merge 1 commit intoMariaDB:10.11from
Conversation
|
|
janlindstrom
force-pushed
the
10.11-MDEV-30612
branch
from
27ed827 to
568dbfb
Compare
janlindstrom
force-pushed
the
10.11-MDEV-30612
branch
from
568dbfb to
300420e
Compare
Setting thd->lex->definer is excessive as it's only used within the function call. Moreover, it would lead to a use-after-free on the second execution of a CREATE TRIGGER prepared statement.
janlindstrom
force-pushed
the
10.11-MDEV-30612
branch
from
300420e to
e6f6ab9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting thd->lex->definer is excessive as it's only used within the function call.
Moreover, it would lead to a use-after-free on the second execution of a CREATE TRIGGER prepared statement.