Skip to content
/ server Public

MDEV-35767: Prevent MTR from overwriting list-like options in test-specific .cnf files #4792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MicheleFilisina wants to merge 4 commits into
base: main
Choose a base branch
from
+24 −0
Open

MDEV-35767: Prevent MTR from overwriting list-like options in test-specific .cnf files #4792

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2186a4f
feat: Enable and test parsing of multiple replicate-do-table options.
MicheleFilisina Mar 12, 2026
7f43dbb
test: Add `not_embedded.inc` to prevent the list parsing test from ru…
MicheleFilisina Mar 12, 2026
221ee43
MTR Overwrites Test-Specific .cnf File Options On Duplicate Option
MicheleFilisina Mar 13, 2026
546f020
MTR Overwrites Test-Specific .cnf File Options On Duplicate Option
MicheleFilisina Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions mysql-test/lib/My/Config.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ my %multipart_options=
(
"plugin-load-add" => 1,
"optimizer-switch" => 1,
"replicate-do-table" => 1,
Copy link
Member

@gkodinov gkodinov Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only addition that should be kept. Also, please add a unit tests for this in mariadb-test-run.pl!

);


Expand Down
6 changes: 6 additions & 0 deletions mysql-test/main/list_parsing.cnf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
!include include/default_my.cnf

[mysqld.1]
replicate_do_table=test.t1
replicate_do_table=test.t2
replicate_do_table=test.t3
9 changes: 9 additions & 0 deletions mysql-test/main/list_parsing.result
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
SELECT GROUP_CONCAT(tbl ORDER BY tbl) AS sorted_replicate_do_table
FROM JSON_TABLE(
CONCAT('["', REPLACE(@@replicate_do_table, ',', '","'), '"]'),
'$[*]' COLUMNS (
tbl VARCHAR(255) PATH '$'
)
) AS jt;
sorted_replicate_do_table
test.t1,test.t2,test.t3
8 changes: 8 additions & 0 deletions mysql-test/main/list_parsing.test
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
--source include/not_embedded.inc
SELECT GROUP_CONCAT(tbl ORDER BY tbl) AS sorted_replicate_do_table
FROM JSON_TABLE(
CONCAT('["', REPLACE(@@replicate_do_table, ',', '","'), '"]'),
'$[*]' COLUMNS (
tbl VARCHAR(255) PATH '$'
)
) AS jt;