MDEV-39028 DROP PARTITION should only require DROP privilege#4779
Open
FarihaIS wants to merge 1 commit intoMariaDB:10.6from
Open
MDEV-39028 DROP PARTITION should only require DROP privilege#4779FarihaIS wants to merge 1 commit intoMariaDB:10.6from
FarihaIS wants to merge 1 commit intoMariaDB:10.6from
Conversation
ALTER TABLE ... DROP PARTITION requires both ALTER and DROP privileges, which is inconsistent with TRUNCATE PARTITION that only requires DROP. This prevents fine-grained privilege separation since users who need to drop partitions must also be granted ALTER, allowing them to perform any other DDL changes on the table. Change DROP PARTITION to require only DROP privilege, consistent with TRUNCATE PARTITION. Users allowed to drop the table should also be allowed to drop partitions without needing ALTER rights. All new code of the whole pull request, including one or several files that are either new files or modified ones, are contributed under the BSD-new license. I am contributing on behalf of my employer Amazon Web Services, Inc.
grooverdan
reviewed
Mar 11, 2026
|
|
||
| DROP TABLE t1; | ||
| DROP USER mysqltest_2@localhost; | ||
| DROP DATABASE mysqltest_2; |
Member
gkodinov
approved these changes
Mar 11, 2026
Member
gkodinov
left a comment
There was a problem hiding this comment.
This is a preliminary review. Please sort out the CLA bot : click on the button and choose the right license. I know it's a formality, but it's easier if we have a unified way to check about the license IMHO.
Otherwise, please work with the assigned final reviewer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ALTER TABLE ... DROP PARTITIONrequires bothALTERandDROPprivileges, which is inconsistent withTRUNCATE PARTITIONthat only requiresDROP. This prevents fine-grained privilege separation since users who need to drop partitions must also be grantedALTER, allowing them to perform any other DDL changes on the table.Change
DROP PARTITIONto require onlyDROPprivilege, consistent withTRUNCATE PARTITION. Users allowed to drop the table should also be allowed to drop partitions without needingALTERrights.Release Notes
N/A
How can this PR be tested?
Execute the
main.partition_granttest in mysql-test-run. This commit adds a test inpartition_grant.test.Before the fix
A user needs both
ALTERandDROPprivileges toDROP PARTITION:After the fix
A user needs only
DROPprivilege toDROP PARTITION.Basing the PR against the correct MariaDB version
Copyright
All new code of the whole pull request, including one or several files that are either new files or modified ones, are contributed under the BSD-new license. I am contributing on behalf of my employer Amazon Web Services, Inc.