MDEV-38721: refactor hierarchical read traversal into helper#4774
Draft
luvjeetk wants to merge 1 commit intoMariaDB:mainfrom
Draft
MDEV-38721: refactor hierarchical read traversal into helper#4774luvjeetk wants to merge 1 commit intoMariaDB:mainfrom
luvjeetk wants to merge 1 commit intoMariaDB:mainfrom
Conversation
gkodinov
added
the
External Contribution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preparatory refactor for MDEV-38721 (VF-HNSW).
This change extracts the existing read-path hierarchical traversal from
mhnsw_read_first()into a dedicated helper function. Behavior is intended to stay unchanged.Why
Changes
sql/vector_mhnsw.ccsearch_hierarchical_read(...)mhnsw_read_first()with helper callVerification
cmake --build build -j4 --target sql cd build/mysql-test ./mariadb-test-run.pl main.vectorLocal result: pass (
aria,innodb,myisam).