MDBF-1201: add --view tests to branch protection#980
Open
RazvanLiviuVarzaru wants to merge 1 commit into
Open
Conversation
Only known green mtr tests under --view-protocol, i.e. --suite=main. MDEV-40142 should be fixed before adding the builder to branch protection.
fauust
approved these changes
Jun 25, 2026
| util.BuilderConfig( | ||
| name="amd64-debian-12-debug-view", | ||
| workernames=workers["x64-bbw-docker-debian-12-debug-view"], | ||
| tags=["Ubuntu", "quick", "gcc", "debug", "protected"], |
Member
|
Curious on the rational of a new builder for this. Is a ~2 min build for a ~2 min test. Having a separate builder is allowing for a branch protection to run across multiple machines as fast as the slowest builder, which seems to be amd64-ubuntu-2204-debug / amd64-ubuntu-2204-debug. Could the view protocol test be appended to an existing amd64-debian-11-debug-ps-embedded or amd64-debian-12-debug-embedded? I notice (sampled rather than full analysis) the longer runs on these seem to be the compile step, or than the mtr step so its a sunken cost. The basis of a reduction is a shorter, more visible (on GH) list of protected branch builders, and a small amount of overhead reduction as by all accounts resources are a bit precious. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only known green mtr tests under --view-protocol, i.e. --suite=main.
MDEV-40142 should be fixed before adding the builder to branch protection.