tarball checksum check - use sha256sum -c#510
Open
grooverdan wants to merge 2 commits intoMariaDB:devfrom
Open
tarball checksum check - use sha256sum -c#510grooverdan wants to merge 2 commits intoMariaDB:devfrom
grooverdan wants to merge 2 commits intoMariaDB:devfrom
Conversation
There where some failures. Might be a divering implemnation on output but eitherway, sha256sum can check directly without needed to do the comparision in bash. Adjust path so the tarball can be found by sha256sum.
Collaborator
RazvanLiviuVarzaru
left a comment
RazvanLiviuVarzaru
left a comment
There was a problem hiding this comment.
This change affects all builders , looks ok but after merge needs a regression test on DEV .
I suggest printing checksum's in standard output so we can track at runtime what is really happening.
Collaborator
|
Looks OK but yes, it needs testing before merge in prod since it will impact every builder. |
RazvanLiviuVarzaru
approved these changes
Jul 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There where some failures. Might be a divering implemnation on output but eitherway, sha256sum can check directly without needed to do the comparision in bash.
Adjust path so the tarball can be found by sha256sum.