Recovery Mode: Run iteration 1 of the recovered data store to eliminate the skew in the first iteration + sync - #9
Open
ganeles wants to merge 1 commit into
Conversation
natively written by the fill, while iterations 2+ ran on a datadir rewritten by cp during restore. On virtualized storage the restored copy is served measurably faster, making iteration 1 consistently 14-28% slower on IO-bound workloads. Fix: after creating the restore image, immediately restore from it so iteration 1 starts from the same physical state as later iterations, and sync before DbStart so restore writeback completes while the database is stopped."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With --database-iteration-mode=restore, iteration 1 ran on the datadir
natively written by the fill, while iterations 2+ ran on a datadir
rewritten by cp during restore. On virtualized storage the restored
copy is served measurably faster, making iteration 1 consistently
14-28% slower on IO-bound workloads.
Fix: after creating the restore image, immediately restore from it so
iteration 1 starts from the same physical state as later iterations,
and sync before DbStart so restore writeback completes while the
database is stopped."