Open
Conversation
... instead of implicitly by not saving the cache entry at all.
The "Yes" option is back to meaning "read it from now on"; "read it this time only" is now "Once".
Owner
|
I prefer (my) plugins to be as simple as possible. Thus tell me which is the use case for saying "N" permanently? This way you can match projects no matter where they are located. or such. Reading your long message alone scares me (and would scare users). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've just started using local_vimrc. It rocks!
Here's an enhancement. The answers it accepts to its prompt are asymmetrical. Only yes is "sticky"; if you say no, it asks you again the next time, and the next, ....
Basically, there are two independent questions encompassed by that prompt:
yielding, of course, four possible combinations, of which only two are implemented.
This branch implements the other two.
I actually came up with two variants. Implementations are identical; it's just the names for the choices offered to the user that are different.
One variant, which I'll refer to as YONV for obvious reasons, gives the user these options:
That's what's in this PR.
The other variant, YNAV, is:
The advantages of YNAV are that yes and no "match", in that neither one is sticky; and the words always and never have nicely matching sticky meanings to go with the sticky choices they represent. The down side is that yes becomes non-sticky, which isn't backward compatible.
YONV is backward compatible; it preserves the current meanings of both yes and no. Plus, I kind of like once as the name for its option. But yes and no remain asymmetrical -- one sticky, one not -- which goes against the grain for me.
In the end, I can't decide which I prefer. So I'm offering you both choices ... um, meta-choices I guess :-) Assuming you like this idea at all, please pick one of the PRs to review, and just close the other one. And speaking of review, this is my first attempt at nontrivial VimL, so please review it especially carefully.
Thanks.